mwoffliner icon indicating copy to clipboard operation
mwoffliner copied to clipboard

Published 20 hours ago • verified publisher icon openzim

Incorrect image display in the Gallery

Open Ubuntu-2020 opened this issue 3 years ago • 15 comments

Kiwix extension for FireFox. If the word thumb is written in the Photo Gallery, then the image in the ZIM file is displayed with an error (second picture): Error second image

And this is what the Gallery in Wikipedia looks like: Original-web

Ubuntu-2020 avatar Apr 04 '21 14:04 Ubuntu-2020

@MananJethwani A nice bug for you ;)

kelson42 avatar Apr 04 '21 15:04 kelson42

will start working on it soon

MananJethwani avatar Apr 05 '21 21:04 MananJethwani

@kelson42 this is because of different width and height of image at Wikipedia, open the page source and search for Tem2-215 observe that width is 120 but when we fetch the mobile version the same tag has a width 300 same is for the height.

so final point is it's an upstream bug.

MananJethwani avatar Apr 16 '21 15:04 MananJethwani

@MananJethwani I don't have verified, but please open an upstream bug (an link it here), if the upstream HTML is broken.

kelson42 avatar Apr 26 '21 11:04 kelson42

@kelson42 done https://phabricator.wikimedia.org/T281125

MananJethwani avatar Apr 26 '21 12:04 MananJethwani

@MananJethwani @kelson42 The same situation Diego Garcia in ZIM file: Diego-Garsia

And this is what the Diego Garcia in Wikipedia looks like: Diego-Garsia wiki

PS: maybe the error has already been fixed, I just can't check.

Ubuntu-2020 avatar May 24 '21 13:05 Ubuntu-2020

This issue has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.

stale[bot] avatar Jul 24 '21 00:07 stale[bot]

This issue has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.

stale[bot] avatar Sep 22 '21 06:09 stale[bot]

This issue has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.

stale[bot] avatar Sep 21 '22 03:09 stale[bot]

https://library.kiwix.org/viewer#wikipedia_ru_all_maxi/A/%D0%A2%D0%AD%D0%9C2 LGTM now. But https://library.kiwix.org/viewer#wikipedia_ru_all_maxi/A/%D0%94%D0%B8%D0%B5%D0%B3%D0%BE-%D0%93%D0%B0%D1%80%D1%81%D0%B8%D1%8F is still wrong.

kelson42 avatar Mar 23 '23 20:03 kelson42

@pavel-karatsiuba Please do the analysis

kelson42 avatar Mar 23 '23 20:03 kelson42

From API we are getting images with the bigger size. It is an upstream bug: page with bug We can fix it by adding a function to treat the gallery section.

pavel-karatsiuba avatar Mar 24 '23 16:03 pavel-karatsiuba

@pavel-karatsiuba Then please open bug upstream at https://phabricator.wikimedia.org/ and link both tickets together.

kelson42 avatar Mar 26 '23 15:03 kelson42

@kelson42 Upstream ticket created: https://phabricator.wikimedia.org/T333122

pavel-karatsiuba avatar Mar 26 '23 19:03 pavel-karatsiuba

@pavel-karatsiuba Thx, it looks like it will be deprecated by implementing https://github.com/openzim/mwoffliner/issues/1664

kelson42 avatar Apr 05 '23 13:04 kelson42