mwoffliner icon indicating copy to clipboard operation
mwoffliner copied to clipboard

Older version or different skins of mediawiki have different modules (Unable to hack startup module)

Open MananJethwani opened this issue 3 years ago • 7 comments

like in case of https://artofproblemsolving.com/wiki/ the content of startupscript is different most probably because of the older version or the different skin they use. this causes a problem in resource loading as we hack a startup script considering the latest code in it and also the modules loaded for this version or skin is different newer version are using base modules mediawiki.base and jquery while this site uses mediawiki and jquery

MananJethwani avatar Mar 11 '21 09:03 MananJethwani

to solve #1402 we need to fix this first

MananJethwani avatar Mar 11 '21 12:03 MananJethwani

@kelson42 do you have anything in mind for what I should do?.....I have one suggestion we should use the mediawiki version to decide which modules to download and how to hack them

MananJethwani avatar Mar 11 '21 12:03 MananJethwani

@MananJethwani Which version are we talking about here? When this has been released?

kelson42 avatar Mar 15 '21 06:03 kelson42

I am talking about the mediawiki version....if a page is using older mediawiki version the base modules are different look at this here https://farm.openzim.org/pipeline/08b73d234bcd752699fc1606/debug, it fails because content of startup module is different and names of base module in this different startup module are different...so we should change our method and base modules depending on version and skins

MananJethwani avatar Mar 29 '21 16:03 MananJethwani

This issue has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.

stale[bot] avatar Jun 02 '21 16:06 stale[bot]

This issue has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.

stale[bot] avatar Apr 16 '22 05:04 stale[bot]

This issue has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.

stale[bot] avatar Sep 21 '22 03:09 stale[bot]

Then we should clearly have a better code to support few different versions.

kelson42 avatar Jan 20 '23 18:01 kelson42

We have support all the Mediawiki from 1.27.0. Website artofproblemsolving.comuse (now) version 1.31, so it is now supported by MWoffliner. Recipe is here https://farm.openzim.org/recipes/art_of_problem_solving and even if it still fails, this is not because of this problem. If we have problems to hack the startup module on a Mediawiki more recent than 1.27, then this is a bug and it should be fixed.

kelson42 avatar Feb 04 '23 13:02 kelson42