mwoffliner icon indicating copy to clipboard operation
mwoffliner copied to clipboard

Landing page is missing

Open ghost opened this issue 5 years ago • 7 comments

Empty page with only a footer legal disclaimer

https://library.kiwix.org/wiktionary_ay_all_nopic https://library.kiwix.org/wikiquote_ga_all_nopic https://library.kiwix.org/wikivoyage_es_all_maxi https://library.kiwix.org/wikivoyage_ps_all_maxi https://library.kiwix.org/wikivoyage_es_all_nopic https://library.kiwix.org/wikivoyage_es_all_maxi https://library.kiwix.org/wikibooks_ky_all_nopic https://library.kiwix.org/wiktionary_ky_all_nopic https://library.kiwix.org/wiktionary_ks_all_nopic https://library.kiwix.org/wikipedia_diq_all_nopic https://library.kiwix.org/wikivoyage_ps_all_nopic

ghost avatar Oct 28 '19 13:10 ghost

This issue has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.

stale[bot] avatar Dec 28 '19 07:12 stale[bot]

Here we have many cases:

  • Many closed Wikibooks. Zimfarm does not make them anymore and I have removed old ZIM files
  • Few other are OK now
  • Parts are because of #984

kelson42 avatar Apr 25 '20 10:04 kelson42

Why http://library.kiwix.org/wikipedia_cv_all_maxi is empty is not clear

kelson42 avatar Apr 25 '20 10:04 kelson42

This issue has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.

stale[bot] avatar Jun 24 '20 10:06 stale[bot]

Most of the problems have been fixed, but https://library.kiwix.org/wikivoyage_es_all_nopic is still empty. @MananJethwani Maybe you have an idea?

kelson42 avatar Jan 07 '21 21:01 kelson42

@kelson42 strange content is present there but never shown Screenshot from 2021-01-08 13-46-39

might be because section id is not provided there

MananJethwani avatar Jan 08 '21 08:01 MananJethwani

This issue has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.

stale[bot] avatar Jun 02 '21 16:06 stale[bot]

@pavel-karatsiuba Could you please for each of the few left ones give the explanation here?

kelson42 avatar Apr 05 '23 13:04 kelson42

I visited each page and also the original pages. This is the result: https://library.kiwix.org/wikiquote_ga_all_nopic The original page is not existing

https://library.kiwix.org/wikivoyage_es_all_maxi https://library.kiwix.org/wikivoyage_es_all_nopic https://library.kiwix.org/wikivoyage_es_all_maxi A lot of JS errors in the browser console. I think some js files were not downloaded

https://library.kiwix.org/wikivoyage_ps_all_maxi The page is here but without images. Some js errors in the browser console

https://library.kiwix.org/wikivoyage_ps_all_nopic works fine

Also I scraped each page locally and I have got the same result.

pavel-karatsiuba avatar Apr 06 '23 07:04 pavel-karatsiuba

@pavel-karatsiuba I know this is what the ticket explain. My question is why we have missing or empy welcome pages? Check the recipes as well on Zimfarm.

kelson42 avatar Apr 06 '23 08:04 kelson42

On each page, the content is present but it is hidden. Each page here presents two content sections, one hidden by CSS class .nomobile and the other hidden by CSS class .mf-mobile-only. .nomobile rule is added from mwoffliner:

.nomobile {
  display: none,
}

.mf-mobile-only rule is added from wikivoyage.org CSS:

.mf-mobile-only {
  display: none,
}

pavel-karatsiuba avatar Apr 06 '23 14:04 pavel-karatsiuba

why these css rules are here? do we have added them manually? any good reason to keep them? where are they exactly?

kelson42 avatar Apr 06 '23 14:04 kelson42

.nomobile rule was added to mwoffliner 6 years ago: inserted_style.css. It is used to hide the section for desktop browsers.

.mf-mobile-only rule is coming from wikivoyage.org CSS.

A simple solution is to add CSS rule:

div.mf-mobile-only{
    display: block;
}

pavel-karatsiuba avatar Apr 06 '23 15:04 pavel-karatsiuba