Update test files
counterParsing
- replace macro with global variable
defaultIndexdata
- replace arithmetic operations with floating point comparison macro
error_in_creator
- reduce duplication of template test parameters as described in the comment
parseLongPath
- succinct assertions using tuple value comparisons
@mgautierfr Can you please review?
Thanks for the review @veloman-yunkan. I was working on another change to include icu.wrap in subprojects, however, decided to PR these changes separately. The commit message included both by mistake. I've amended, rebased and force-pushed the changes.
There's no specific issue being resolved in this PR - just code simplification.
@tusharpm I think that the commit message is still somewhat misleading - it creates an impression that something had changed in the API, dependencies, compiler, etc, so the test files had to be updated to keep things working. Please change the commit message to "Some clean-up in test files" and we will merge the PR.
@tusharpm @veloman-yunkan Can one of you please complete this PR so we can merge it?
Codecov Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 57.69%. Comparing base (e40e439) to head (d7492e5).
:warning: Report is 6 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #910 +/- ##
=======================================
Coverage 57.69% 57.69%
=======================================
Files 103 103
Lines 4976 4976
Branches 2083 2083
=======================================
Hits 2871 2871
Misses 713 713
Partials 1392 1392
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
Please change the commit message to "Some clean-up in test files" and we will merge the PR.
Well, I did it myself.