gutenberg icon indicating copy to clipboard operation
gutenberg copied to clipboard

Get rid of the search field inside the ZIM

Open benoit74 opened this issue 1 month ago • 10 comments

We should not have a search field inside the ZIM UI.

Content is already properly indexed (at least since 3.0.0, not sure before that):

  • in the title index (from ZIM perspective) to be able to search for a book title or author
  • in the full-text search index to be able to search for book content

I don't see what could be done best with a in-ZIM JS-based search, Xapian is far superior.

Not speaking about the fact having two search fields is very confusing.

benoit74 avatar Nov 02 '25 17:11 benoit74

Only limitation is that we cannot make complex search like searching only for an author or only a title. But I feel like it is an acceptable price to pay given the much leaner user experience.

benoit74 avatar Nov 02 '25 17:11 benoit74

Agree for the title search box, but for the author search box it seems a bit more complex, in particular in multilanguage ZIM. We should at least create pages for each author with the list of books he has written.

kelson42 avatar Nov 02 '25 18:11 kelson42

We already have dedicated pages per author. Search for authors already work with the reader search box.

Image

This issue is only about removing the in-ZIM search box which is quite detrimental from my PoV.

Corrolary is probably that we need to enhance a bit the author pages to make it clearer that we are viewing all books of a given author.

benoit74 avatar Nov 02 '25 19:11 benoit74

And it also means that we will get rid of the --title-search CLI option

benoit74 avatar Nov 02 '25 19:11 benoit74

Corrolary is probably that we need to enhance a bit the author pages to make it clearer that we are viewing all books of a given author.

Yes and I would like to understand how books are sorted in case of multilang ZIM.

But it seems we agree on the goal and that we are already almost there.

kelson42 avatar Nov 02 '25 20:11 kelson42

I'm pretty sure sorting of search results is purely up to Xapian decision, hence mostly random when title is identical on multiple search entries.

benoit74 avatar Nov 02 '25 20:11 benoit74

I'm pretty sure sorting of search results is purely up to Xapian decision, hence mostly random when title is identical on multiple search entries.

I mean on the author page, for each author the books should be grouped by language.

kelson42 avatar Nov 02 '25 20:11 kelson42

I mean on the author page, for each author the books should be grouped by language.

OK, that's a new idea. Not sure many authors have books in many languages, but it might exists indeed, and grouping by language would help.

benoit74 avatar Nov 02 '25 20:11 benoit74

@VikramAditya33 for now, simply remove the --title-search option ; beware this needs to be removed from offfliner-definition.json as well (this is a file used by Zimfarm to display its UI). I will move the question/idea about presenting author view differently to another issue, I'm not yet convinced about what to do / how.

benoit74 avatar Nov 28 '25 07:11 benoit74

Moved the question about author view display to https://github.com/openzim/gutenberg/issues/361

benoit74 avatar Nov 28 '25 07:11 benoit74