gutenberg icon indicating copy to clipboard operation
gutenberg copied to clipboard

Definition for current book Interface

Open Lorrainnn opened this issue 6 months ago • 4 comments

  1. what's cover_page for?
  2. If bookshelf feature is no longer being maintined, should we delete this (all related bookshelf codes) Image

Lorrainnn avatar Jul 09 '25 03:07 Lorrainnn

  1. looking at the code and DB content will probably help yourself ; a quick look seems to indicate it's a boolean indicating if the book has a cover image available or not ; please confirm
  2. see https://github.com/openzim/gutenberg/issues/265

benoit74 avatar Jul 10 '25 07:07 benoit74

Btw, it probably means that current UI is not properly handling the case where a book has no cover image (quite rare, but it does happen, at least it did happen in the past).

benoit74 avatar Jul 11 '25 07:07 benoit74

cover_page is used to indicate if book has a cover image if I'm not mistaken. Should probably be renamed.

bookshelf has been replace by lcc shelve.

Keeping issue open until first point is confirmed and renaming is done, but not much left todo.

benoit74 avatar Nov 03 '25 07:11 benoit74

@VikramAditya33 can you confirm that cover_page is in fact used as a boolean indicating the book has a cover image? If yes, please rename it to a more meaningful name + change type to bool

benoit74 avatar Nov 28 '25 06:11 benoit74