zfs icon indicating copy to clipboard operation
zfs copied to clipboard

zfs-2.2.3 patchset

Open tonyhutter opened this issue 1 year ago • 16 comments

Motivation and Context

Support 6.7 kernel and various other fixes.

Description

Proposed patchset for zfs-2.2.3

How Has This Been Tested?

ZTS will test

Types of changes

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Performance enhancement (non-breaking change which improves efficiency)
  • [ ] Code cleanup (non-breaking change which makes code smaller or more readable)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)
  • [ ] Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • [ ] Documentation (a change to man pages or other documentation)

Checklist:

  • [ ] My code follows the OpenZFS code style requirements.
  • [ ] I have updated the documentation accordingly.
  • [ ] I have read the contributing document.
  • [ ] I have added tests to cover my changes.
  • [ ] I have run the ZFS Test Suite with this change applied.
  • [ ] All commit messages are properly formatted and contain Signed-off-by.

tonyhutter avatar Jan 29 '24 23:01 tonyhutter

Please backport 07e95b4670dc421ec726a2b4efa97a22fe572005 (#15716), it fixes FreeBSD userspace build after #15662

mmatuska avatar Jan 30 '24 08:01 mmatuska

@mmatuska thanks for that! I included it in my latest push.

tonyhutter avatar Jan 30 '24 21:01 tonyhutter

Looks like everything is passing except some FreeBSD block cloning tests (http://build.openzfs.org/builders/FreeBSD%20stable%2F13%20amd64%20%28TEST%29/builds/1548). I'll see if I can reproduce those failures in a VM.

tonyhutter avatar Feb 01 '24 21:02 tonyhutter

May I ask to also include #15842? Thanks for considering!

Vlad1mir-D avatar Feb 02 '24 15:02 Vlad1mir-D

@Vlad1mir-D yes, we'll pull that in after it's merged to master.

tonyhutter avatar Feb 02 '24 17:02 tonyhutter

@Vlad1mir-D yes, we'll pull that in after it's merged to master.

Thanks a lot!

Vlad1mir-D avatar Feb 04 '24 15:02 Vlad1mir-D

@tonyhutter can you please include https://github.com/openzfs/zfs/pull/15843?

umsaleem avatar Feb 06 '24 04:02 umsaleem

another request

May I ask to consider including https://github.com/openzfs/zfs/pull/15584? I'll understand if this out of scope of this minor version bump 🫠

Thanks!

shumvgolove avatar Feb 09 '24 10:02 shumvgolove

The newly posted #15874 is an important BRT fix as well

mmatuska avatar Feb 10 '24 09:02 mmatuska

Please note #15883 was opened as well

mmatuska avatar Feb 12 '24 09:02 mmatuska

2.2.3 is going to be such a great!

Vlad1mir-D avatar Feb 12 '24 12:02 Vlad1mir-D

@mmatuska thanks, I'll pull those two in once they're merged.

tonyhutter avatar Feb 12 '24 17:02 tonyhutter

All the builders are failing cp_files_002_pos. I'm looking into it.

tonyhutter avatar Feb 12 '24 17:02 tonyhutter

All the builders are failing cp_files_002_pos

It was failing because zfs_bclone_enabled=0 by default on the 2.2.x branch. I just added a commit to enable it when running the tests.

tonyhutter avatar Feb 12 '24 21:02 tonyhutter

Release! Release! :clap:

Vlad1mir-D avatar Feb 14 '24 11:02 Vlad1mir-D

Looks like we're passing on everything except FreeBSD, which is failing on the block cloning tests:

Tests with results other than PASS that are unexpected:
    FAIL bclone/bclone_crossfs_data (expected PASS)
    FAIL bclone/bclone_diffprops_all (expected PASS)
    FAIL bclone/bclone_diffprops_checksum (expected PASS)
    FAIL bclone/bclone_diffprops_compress (expected PASS)
    FAIL bclone/bclone_diffprops_copies (expected PASS)
    FAIL bclone/bclone_diffprops_recordsize (expected PASS)
    FAIL bclone/bclone_prop_sync (expected PASS)
    FAIL bclone/bclone_samefs_data (expected PASS)
    FAIL block_cloning/block_cloning_clone_mmap_cached (expected PASS)
    FAIL block_cloning/block_cloning_clone_mmap_write (expected PASS)
    FAIL block_cloning/block_cloning_copyfilerange (expected PASS)
    FAIL block_cloning/block_cloning_copyfilerange_cross_dataset (expected PASS)
    FAIL block_cloning/block_cloning_copyfilerange_fallback (expected PASS)
    FAIL block_cloning/block_cloning_copyfilerange_partial (expected PASS)
    FAIL block_cloning/block_cloning_cross_enc_dataset (expected PASS)
    FAIL block_cloning/block_cloning_lwb_buffer_overflow (expected PASS)
    FAIL block_cloning/block_cloning_replay (expected PASS)
    FAIL block_cloning/block_cloning_replay_encrypted (expected PASS)

https://build.openzfs.org/builders/FreeBSD%20stable%2F13%20amd64%20%28TEST%29/builds/1584

tonyhutter avatar Feb 14 '24 20:02 tonyhutter

Released: https://github.com/openzfs/zfs/releases/tag/zfs-2.2.3

tonyhutter avatar Feb 22 '24 21:02 tonyhutter