zfs icon indicating copy to clipboard operation
zfs copied to clipboard

Published 20 hours ago • verified publisher icon openzfs

Remove unused variants of Skein

Open mcmilk opened this issue 1 year ago • 5 comments

The variants Skein-256 and Skein-1024 aren't used within OpenZFS.

Motivation and Context

Cleanup icp module - encryption and hashing.

Description

The code is public domain, so there is ne need for additional licensing information: THIRDPARTYLICENSE* removed, and CDDL headers added. Also the debugging and the two unused variants got removed.

How Has This Been Tested?

I compiled on FreeBSD and Linux machines. No big endian machine currently :(

Types of changes

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Performance enhancement (non-breaking change which improves efficiency)
  • [x] Code cleanup (non-breaking change which makes code smaller or more readable)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)
  • [ ] Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • [ ] Documentation (a change to man pages or other documentation)

Checklist:

  • [x] My code follows the OpenZFS code style requirements.
  • [ ] I have updated the documentation accordingly.
  • [x] I have read the contributing document.
  • [ ] I have added tests to cover my changes.
  • [x] I have run the ZFS Test Suite with this change applied.
  • [x] All commit messages are properly formatted and contain Signed-off-by.

mcmilk avatar Apr 02 '23 17:04 mcmilk

No big endian machine currently

It builds on my big-endian POWER7 machine, with Linux 4.1 and 6.1. No further testings are done because current running kernel can't be used to test zfs.ko.

Low-power avatar Apr 05 '23 07:04 Low-power

No big endian machine currently

It builds on my big-endian POWER7 machine, with Linux 4.1 and 6.1. No further testings are done because current running kernel can't be used to test zfs.ko.

@Low-power - I have access to POWER8 and POWER9 OpenStack VMs - is there some ready to use FreeBSD 13.x Disk Image somewhere? I would like to setup an big endian FreeBSD buildbot then. Also one for ppc64le ... maybe I don't have to search a lot, when you can tell me some fast link ;-)

mcmilk avatar Apr 12 '23 11:04 mcmilk

Unfortunately I didn't have my hands on FreeBSD/powerpc64 right this time. I only experienced working FreeBSD/powerpc64 live system under QEMU/KVM, so I guess using the standard iso images should be fine.

Low-power avatar Apr 13 '23 05:04 Low-power