zfs icon indicating copy to clipboard operation
zfs copied to clipboard

CodeQL Macos workflow

Open andrewc12 opened this issue 1 year ago • 3 comments

Motivation and Context

The different files included in the different builds might not be scanned if we build on only one system.

Description

Run codeql on a macos system to catch problems in macos specific code.

How Has This Been Tested?

Types of changes

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Performance enhancement (non-breaking change which improves efficiency)
  • [ ] Code cleanup (non-breaking change which makes code smaller or more readable)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)
  • [ ] Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • [ ] Documentation (a change to man pages or other documentation)

Checklist:

  • [ ] My code follows the OpenZFS code style requirements.
  • [ ] I have updated the documentation accordingly.
  • [ ] I have read the contributing document.
  • [ ] I have added tests to cover my changes.
  • [ ] I have run the ZFS Test Suite with this change applied.
  • [ ] All commit messages are properly formatted and contain Signed-off-by.

andrewc12 avatar Apr 02 '23 04:04 andrewc12

⚠️ This PR needs PR #12110 to be merged first ⚠️

andrewc12 avatar Apr 02 '23 04:04 andrewc12

@ryao just checking with you that we need OS specific codeql workflows.

andrewc12 avatar Apr 02 '23 04:04 andrewc12

@ryao just checking with you that we need OS specific codeql workflows.

Yes, although this should not be merged until MacOS support is merged.

ryao avatar Apr 03 '23 19:04 ryao