zfs icon indicating copy to clipboard operation
zfs copied to clipboard

Combined asm for some x86_64 ports

Open andrewc12 opened this issue 2 years ago • 4 comments

Create a single module/lua/setjmp/setjmp_x86_64.S from the following repositories openzfs/zfs/master openzfsonosx/openzfs-fork/macOS for testing, discussion and possible inclusion upstream

https://github.com/openzfs/zfs/pull/14169 https://github.com/openzfsonwindows/openzfs/pull/176 https://github.com/openzfsonosx/openzfs/pull/115

Signed-off-by: Andrew Innes [email protected]

andrewc12 avatar Nov 10 '22 10:11 andrewc12

@solbjorn @behlendorf do you see any problems with how I've refactored this?

andrewc12 avatar Nov 10 '22 13:11 andrewc12

Looks okay to me. One thing I'd add comments like /* __APPLE__ */ near elses and endifs, otherwise it's sometimes hard to track where is what.

solbjorn avatar Nov 17 '22 18:11 solbjorn

@andrewc12 if you're happy with the current version would you mind rebasing it against the latest master source and marking it ready for review.

behlendorf avatar Nov 29 '22 17:11 behlendorf

@behlendorf I would gladly, but atm @lundman is currently trying to merge the seperate asm used by windows which also touches this file.

I would love to knock out all of them at once which was the original intent of this PR, so no matter how it goes I'll be waiting untill after he's finished his work. 🙂

andrewc12 avatar Nov 29 '22 18:11 andrewc12

I would add / modify the assembly support for SHA2 / BLAKE3 ... when the windows branch is merged some day.

mcmilk avatar Dec 06 '22 18:12 mcmilk

I might revisit this again in the future after https://github.com/openzfs/zfs/pull/14228 is merged

andrewc12 avatar Dec 23 '22 08:12 andrewc12

Might not be clear, but #14228 takes care of all the changes in here and expands it to make all assembler files sharable with windows and macOS. Moving the header file was the hardest part tho.

lundman avatar Dec 23 '22 08:12 lundman

Ahh sweet. @behlendorf can you take a look at that one instead?

andrewc12 avatar Dec 23 '22 08:12 andrewc12