openyurtio
<Proposal> Optimize the pods recovery efficiency when edge nodes restart proposal
…roposal
What type of PR is this?
Uncomment only one
/kind <>line, hit enter to put that in a new line, and remove leading whitespace from that line: /kind bug /kind documentation /kind enhancement /kind good-first-issue /kind feature /kind question /kind design /sig ai /sig iot /sig network /sig storage /sig storage
What this PR does / why we need it:
Optimize the pods recovery efficiency when edge nodes restart proposal
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
other Note
@Sodawyx: GitHub didn't allow me to assign the following users: your_reviewer.
Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. For more information please see the contributor guide
In response to this:
…roposal
What type of PR is this?
Uncomment only one
/kind <>line, hit enter to put that in a new line, and remove leading whitespace from that line: /kind bug /kind documentation /kind enhancement /kind good-first-issue /kind feature /kind question /kind design /sig ai /sig iot /sig network /sig storage /sig storageWhat this PR does / why we need it:
Optimize the pods recovery efficiency when edge nodes restart proposal
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
other Note
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
Welcome @Sodawyx! It looks like this is your first PR to openyurtio/openyurt 🎉
Codecov Report
:exclamation: No coverage uploaded for pull request base (
master@ccf6a85). Click here to learn what that means. The diff coverage isn/a.
@@ Coverage Diff @@
## master #930 +/- ##
=========================================
Coverage ? 45.22%
=========================================
Files ? 85
Lines ? 11857
Branches ? 0
=========================================
Hits ? 5362
Misses ? 6047
Partials ? 448
| Flag | Coverage Δ | |
|---|---|---|
| unittests | 45.22% <0.00%> (?) |
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
![codecov[bot] avatar](https://avatars.githubusercontent.com/in/254?v=4 "Published by a pub.dev verified publisher"){kind=small}
@Sodawyx Thank you for posting proposal. I think that it's not reasonable to optimize yurthub directly for this case. we need to measure the time for each step of node restart, then make decisions how to optimize based on the measure results.
@Sodawyx Please consider comparing differebt restart scenrios to give optimization more lights:
- node without yurthub/OpenYurt (must be connected in this case)
- node connected
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: rambohe-ch, Sodawyx
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [rambohe-ch]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: rambohe-ch, Sodawyx
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [rambohe-ch]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment