openyurt icon indicating copy to clipboard operation
openyurt copied to clipboard

[unit test] improve unit test coverage for yurthub

Open rambohe-ch opened this issue 2 years ago • 3 comments

What would you like to be added: improve unit test coverage for yurthub:

  • current coverage: 45% https://app.codecov.io/gh/openyurtio/openyurt/compare/911/tree/pkg/yurthub

  • target coverage: 70%

Why is this needed: improve unit test coverage for OpenYurt project.

others /kind feature

rambohe-ch avatar Jul 18 '22 10:07 rambohe-ch

Since we're pending at #882 which has great changes on yurthub cache components, could we write unit tests after #882 being merged? Otherwise we have to rewrite these tests later.

Also, we'd better do #857 based on #882, otherwise we have to retest it later.

Congrool avatar Jul 19 '22 02:07 Congrool

Since we're pending at #882 which has great changes on yurthub cache components, could we write unit tests after #882 being merged? Otherwise we have to rewrite these tests later.

Also, we'd better do #857 based on #882, otherwise we have to retest it later.

@Congrool ok, i will focus on reviewing #882 and merge this pull request before unit test.

rambohe-ch avatar Jul 20 '22 02:07 rambohe-ch

/assign donychen1134

donychen1134 avatar Jul 20 '22 06:07 donychen1134