openyurt icon indicating copy to clipboard operation
openyurt copied to clipboard

[feature request]`NodePool Governance Capability`: Add admission webhook

Open Peeknut opened this issue 2 years ago • 5 comments

What would you like to be added: Admission webhook ensures that Node Autonomy and NodePoll Autonomy will not be enabled at the same time. Admission webhook can be described as:

  • Go online and offline with spirit-controller.
  • For the user's request to send Node Autonomy/NodePool Autonomy, check whether one of these autonomy has been enabled, and if so, reject the request.

Why is this needed: As mentioned in the proposal(https://github.com/openyurtio/openyurt/pull/772), since NodePool Autonomy will failover the disconnected nodes, and Node Autonomy is defined as keeping disconnected nodes from failing over, so node autonomy and node pool autonomy cannot be enabled at the same time. We need to use the webhook to limit the two capabilities.

others /kind feature

Peeknut avatar Mar 10 '22 07:03 Peeknut

/assign @LindaYu17

gnunu avatar Mar 11 '22 08:03 gnunu

webhook development complete, waiting for integration with other components. add two validating webhook:

  1. poolcoordiantor-webhook: validate pool-coordinator CR create/update
  2. nodeautonomy-webhook: validate when annotating node as node autonomy

LindaYu17 avatar May 24 '22 09:05 LindaYu17

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Aug 31 '22 00:08 stale[bot]

/pinned

rambohe-ch avatar Sep 01 '22 03:09 rambohe-ch

/pinned

rambohe-ch avatar Sep 01 '22 03:09 rambohe-ch

/close

rambohe-ch avatar Jan 19 '23 08:01 rambohe-ch

@rambohe-ch: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openyurt-bot avatar Jan 19 '23 08:01 openyurt-bot