openyurt
openyurt copied to clipboard
feat: support yurt-manager work in specified namespace
What type of PR is this?
/kind feature
What this PR does / why we need it:
- support gateway controllers work normally in specified namespace;
- CRDs can be templated rather than hard code, so the namespace of conversion webhooks service can be configured in
gateways.raven.openyurt.io
andnodepools.apps.openyurt.io
.
Which issue(s) this PR fixes:
Fixes #1845
Special notes for your reviewer:
/assign @rambohe-ch
Does this PR introduce a user-facing change?
NONE
Welcome @tagGeeY! It looks like this is your first PR to openyurtio/openyurt 🎉
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 52.14%. Comparing base (
74b0a47
) to head (f7610de
). Report is 45 commits behind head on master.
:exclamation: Current head f7610de differs from pull request most recent head ebe4b2a. Consider uploading reports for the commit ebe4b2a to get more accurate results
Additional details and impacted files
@@ Coverage Diff @@
## master #1857 +/- ##
==========================================
- Coverage 52.20% 52.14% -0.06%
==========================================
Files 172 172
Lines 20839 20839
==========================================
- Hits 10879 10867 -12
- Misses 8997 9008 +11
- Partials 963 964 +1
Flag | Coverage Δ | |
---|---|---|
unittests | 52.14% <ø> (-0.06%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@tagGeeY Thanks for raising this pull request. i think we should add another helm chart repo(like yurt-manager-crds) to manage these CRDs
files instead of removing them into template
directory under yurt-manager
chart repo.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: tagGeeY
To complete the pull request process, please assign rambohe-ch
You can assign the PR to them by writing /assign @rambohe-ch
in a comment when ready.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve
in a comment
Approvers can cancel approval by writing /approve cancel
in a comment
Quality Gate passed
Kudos, no new issues were introduced!
0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication
@rambohe-ch OK, I revoked modification in yurt-manager chart.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.