Proposal for improve yurthub cache
What type of PR is this?
Uncomment only one
/kind <>line, hit enter to put that in a new line, and remove leading whitespace from that line: /kind bug /kind documentation /kind enhancement /kind good-first-issue /kind feature /kind question /kind design /sig ai /sig iot /sig network /sig storage
/kind design
What this PR does / why we need it:
- Sorting out the original architecture logic, identifying problems and proposing solutions
- Optimized architectural design, weakened YurtHub cloud-side two patterns code design
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
/assign @rambohe-ch
Does this PR introduce a user-facing change?
other Note
@JameKeal: GitHub didn't allow me to assign the following users: your_reviewer.
Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. For more information please see the contributor guide
In response to this:
What type of PR is this?
Uncomment only one
/kind <>line, hit enter to put that in a new line, and remove leading whitespace from that line: /kind bug /kind documentation /kind enhancement /kind good-first-issue /kind feature /kind question /kind design /sig ai /sig iot /sig network /sig storage/kind design
What this PR does / why we need it:
- Sorting out the original architecture logic, identifying problems and proposing solutions
- Optimized architectural design, weakened YurtHub cloud-side two patterns code design
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
/assign @rambohe-ch
Does this PR introduce a user-facing change?
other Note
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 51.68%. Comparing base (
7fe6fd6) to head (2240828). Report is 213 commits behind head on master.
Additional details and impacted files
@@ Coverage Diff @@
## master #1614 +/- ##
==========================================
+ Coverage 51.42% 51.68% +0.26%
==========================================
Files 134 218 +84
Lines 15947 26521 +10574
==========================================
+ Hits 8200 13707 +5507
- Misses 7001 11574 +4573
- Partials 746 1240 +494
| Flag | Coverage Δ | |
|---|---|---|
| unittests | 51.68% <ø> (+0.26%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: JameKeal
To complete the pull request process, please assign rambohe-ch
You can assign the PR to them by writing /assign @rambohe-ch in a comment when ready.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
Kudos, SonarCloud Quality Gate passed! 
0 Bugs
0 Vulnerabilities
0 Security Hotspots
1 Code Smell
No Coverage information
0.4% Duplication
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
@JameKeal @rambohe-ch Disscussion summary of weekly meeting at 2023.07.26.
- Add metrics for cache, like failed times, data size, etc. @rambohe-ch
- Original atomic
ReplaceComponentListoperation is replaced with multiple operations(like update, add, delete) in this proposal which is not atomic. Considering the case that yurthub is doing such "multiple operations" to cache the list response but failed by crash, the cached data on disk is incompleted and after restoring of yurthub it will use the incomplete data to serve client requests. The situation will not be relieved until the client sends a relist request and the yurthub sucessfully caches the new responses. @Congrool - The underlayer of the
Storeinterface may be diskStorage or etcdStorage. If the interface is modified, the implementation of etcdStorage should also be aligned with it. @Congrool
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
Quality Gate passed
Issues
30 New issues
0 Accepted issues
Measures
0 Security Hotspots
No data about Coverage
0.4% Duplication on New Code
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.