openyurt icon indicating copy to clipboard operation
openyurt copied to clipboard

Published 20 hours ago • verified publisher icon openyurtio

[feature request] deprecated repo `yurt-app-manager-api`

Open huiwq1990 opened this issue 2 years ago • 1 comments

What would you like to be added:

Use api to replace app-manager-api. We need to modify go import which used by openyurt etc.

Why is this needed:

others /kind feature

huiwq1990 avatar Sep 16 '22 11:09 huiwq1990

@huiwq1990 yes, we shoud search all repos and find out all codes that are using yurt-app-manager-api.

rambohe-ch avatar Sep 16 '22 11:09 rambohe-ch

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Dec 15 '22 15:12 stale[bot]

Maybe I can get this done, what specific repositories need to be modified at this point? @rambohe-ch

YTGhost avatar Feb 10 '23 05:02 YTGhost

Maybe I can get this done, what specific repositories need to be modified at this point? @rambohe-ch

@YTGhost maybe we can start from openyurtio/openyurt repo.

rambohe-ch avatar Feb 10 '23 06:02 rambohe-ch

@rambohe-ch The controller migration is now complete and I think it's time to start this work?

YTGhost avatar May 09 '23 08:05 YTGhost

@rambohe-ch The controller migration is now complete and I think it's time to start this work?

@YTGhost yes, would you like to take over this work?

rambohe-ch avatar May 09 '23 11:05 rambohe-ch

@rambohe-ch The controller migration is now complete and I think it's time to start this work?

@YTGhost yes, would you like to take over this work?

/assign

YTGhost avatar May 09 '23 12:05 YTGhost

@YTGhost Do you have any progress about this issue?

rambohe-ch avatar May 22 '23 08:05 rambohe-ch

@YTGhost Do you have any progress about this issue?

@rambohe-ch I see that this part(https://github.com/openyurtio/yurt-app-manager-api/tree/main/pkg/yurtappmanager/client) is not in the api repository, how should this piece be migrated?

YTGhost avatar May 22 '23 08:05 YTGhost

@YTGhost Do you have any progress about this issue?

@rambohe-ch I see that this part(https://github.com/openyurtio/yurt-app-manager-api/tree/main/pkg/yurtappmanager/client) is not in the api repository, how should this piece be migrated?

@YTGhost we should divide this feature into two parts: (take NodePool as a example)

  • import NodePool in yurt-app-manager-api: we can import NodePool in pkg/apis/apps
  • use nodepool client: we can use controller-runtime client to manage nodepool resource.

rambohe-ch avatar May 22 '23 09:05 rambohe-ch