openyurt icon indicating copy to clipboard operation
openyurt copied to clipboard

[WIP] add ota update RESTful API

Open xavier-hou opened this issue 2 years ago • 3 comments

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line: /kind bug /kind documentation /kind enhancement /kind good-first-issue /kind feature /kind question /kind design /sig ai /sig iot /sig network /sig storage

What this PR does / why we need it:

add ota pod update REST API

  1. GET /openyurt.io/v1/pods
  2. POST /openyurt.io/v1/namespaces/{ns}/pods/{podname}/update

Which issue(s) this PR fixes:

Related proposal #921

Special notes for your reviewer:

Does this PR introduce a user-facing change?


other Note

xavier-hou avatar Sep 14 '22 15:09 xavier-hou

@xavier-hou: GitHub didn't allow me to assign the following users: your_reviewer.

Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. For more information please see the contributor guide

In response to this:

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line: /kind bug /kind documentation /kind enhancement /kind good-first-issue /kind feature /kind question /kind design /sig ai /sig iot /sig network /sig storage

What this PR does / why we need it:

add ota pod update REST API

  1. GET /openyurt.io/v1/pods
  2. POST /openyurt.io/v1/namespaces/{ns}/pods/{podname}/update

Which issue(s) this PR fixes:

Related proposal #921

Special notes for your reviewer:

Does this PR introduce a user-facing change?


other Note

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openyurt-bot avatar Sep 14 '22 15:09 openyurt-bot

Codecov Report

Merging #1004 (100f17a) into master (ba10718) will increase coverage by 0.10%. The diff coverage is 54.12%.

@@            Coverage Diff             @@
##           master    #1004      +/-   ##
==========================================
+ Coverage   47.60%   47.71%   +0.10%     
==========================================
  Files          89       90       +1     
  Lines       12548    12651     +103     
==========================================
+ Hits         5974     6036      +62     
- Misses       6059     6093      +34     
- Partials      515      522       +7     
Flag Coverage Δ
unittests 47.71% <54.12%> (+0.10%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/yurthub/server/server.go 0.00% <0.00%> (ø)
pkg/yurthub/otaupdate/ota.go 57.84% <57.84%> (ø)
.../daemonpodupdater/daemon_pod_updater_controller.go 39.39% <0.00%> (+1.36%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Sep 14 '22 15:09 codecov[bot]

Are pods allowed to be updated when the cloud edge is disconnected?

zyjhtangtang avatar Sep 26 '22 07:09 zyjhtangtang

@xavier-hou please fix unit tests error

rambohe-ch avatar Sep 26 '22 10:09 rambohe-ch

/lgtm /approve

rambohe-ch avatar Sep 30 '22 06:09 rambohe-ch

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rambohe-ch, xavier-hou

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openyurt-bot avatar Sep 30 '22 06:09 openyurt-bot