xla icon indicating copy to clipboard operation
xla copied to clipboard

Mark num_outputs as out parameter in PJRT_Executable_OutputDimensions_Args Fixes #25211

Open grewalsk opened this issue 7 months ago • 2 comments

Fixed #25211 by updating the C API header to explicitly mark num_outputs as an output parameter, clarifying the API contract. I also added a new C API test that calls GetOutputDimensions and verifies that num_outputs, dims and dim_sizes are correctly populated.

grewalsk avatar Apr 24 '25 04:04 grewalsk

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Apr 24 '25 04:04 google-cla[bot]

Im having some trouble with the CLA agreement it says an email contributed that, I will fix that and then redo it.

grewalsk avatar Apr 24 '25 05:04 grewalsk

Closing due to inactivity.

allanrenucci avatar Aug 12 '25 11:08 allanrenucci