openwrt
Fix IPv6 to IPv4-only DDNS provider
This PR fixes issues with DDNS scripts when dealing with IPv6 to IPv4-only providers.
@BKPepe Looking for what it'd take to get this merged. LMK
Small Fix - DUCKDNS only has v4 addresses - but supports v6 AAAA records
Logic was added to the existing script redundantly as opposed to adding a new function - which seemed in keeping with the existing code style.
LMK if there are more hoops to get through.
OK, but now you need to squash these commits as the second one is not following the guidelines.
Thanks for the hand holding. I've combined the commits and added the sign-off. LMK if there's still more administratrivia that needs addressing. @GeorgeSapkin
Well, your combined commit still needs to follow the commit guidelines regarding the commit subject format and the message. It needs be something like ddns-scripts: fix IPv6 updates to IPv4-only DDNS providers. Please check the submissions guidelines.
And you need to specify how you run-tested this in the PR description.
@GeorgeSapkin - Okay - "Once More With Feeling"™ I am unsure what you mean by PR description in your comment above - I made a cogent comment in the freshly updated single, signed-off, appropriately titled commit....
LMK & Thanks
I gave the changes a brief look and I feel like this could use a shellcheck.
I gave the changes a brief look and I feel like this could use a shellcheck.
Indeed.. the whole thing is a shellcheck nightmare....
This is "in keeping with existing code style" -- ducks & runs
I can resubmit with sc2806 quotes in place. Not an issue. LMK
I guess it's a bit out of scope for this PR. If you feel like it you could split this into a shellcheck fixing commit and your changes.
Probably ought to test this with forced_ipversion=0/1 on all three clients (wget/curl/uclient_fetch) with all the combinations of v4,v6,dualstack clients and servers. However that's beyond my current level of commitment without more automation at my disposal.