packages icon indicating copy to clipboard operation
packages copied to clipboard

Reapply "postgresql: update to version 16.3"

Open dangowrt opened this issue 1 year ago • 3 comments

Maintainer: me Compile tested: aarch64/cortex-a53 Run tested: -

Description: This reverts commit 3dbefd299a754f09d38db85fdfbbea36870f7d40. openwrt/openwrt@72accd078f fixes the actual issue of 'flex' not working unless the M4 environment variable is set, which isn't done in case of building with CMake or Meson.

I'm going to follow up and update PostgreSQL to 16.4 for the upcoming openwrt-24.10 branch, and then to PostgreSQL 17.0 in the development branch.

dangowrt avatar Sep 27 '24 00:09 dangowrt

Well, I have not specific knowledge, but CI seems to dislike your changes.

 [234/1612] Generating src/fe_utils/psqlscan with a custom command
FAILED: src/fe_utils/psqlscan.c 
/builder/staging_dir/host/bin/python3 ../src/tools/pgflex --builddir . --srcdir .. --privatedir src/fe_utils/psqlscan.c.p --flex /builder/staging_dir/host/bin/flex --perl /builder/staging_dir/host/bin/perl -i ../src/fe_utils/psqlscan.l -o src/fe_utils/psqlscan.c --no-backup --fix-warnings -- -Cfe -p -p
flex: fatal internal error, exec of /builder/shared-workdir/build/staging_dir/host/bin/m4 failed
[235/1612] Compiling C object src/interfaces/libpq/libpq.so.5.16.p/libpq-events.c.o
[236/1612] Compiling C object src/interfaces/libpq/libpq.so.5.16.p/pqexpbuffer.c.o
[237/1612] Compiling C object src/interfaces/libpq/libpq.so.5.16.p/fe-connect.c.o
ninja: build stopped: subcommand failed.
make[2]: *** [Makefile:264: /builder/build_dir/target-mips_24kc_musl/postgresql-16.3/.built] Error 1
make[2]: Leaving directory '/feed/libs/postgresql'
time: package/feeds/packages_ci/postgresql/compile#41.27#17.80#32.34
    ERROR: package/feeds/packages_ci/postgresql failed to build.

hnyman avatar Sep 27 '24 06:09 hnyman

@hnyman This looks like https://github.com/openwrt/openwrt/commit/72accd078f has not yet been applied to the container used for CI. How can we know which commit level the SDK used in the container is on?

dangowrt avatar Sep 27 '24 10:09 dangowrt

You should rebase the PR branch once the SDK has surely been rebuilt in images phase1 buildbot, so that the new CI round gets triggered.

hnyman avatar Sep 27 '24 11:09 hnyman

No updates in over a year with merge conflicts. Closing as stale. Feel free to reopen if anything changes.

GeorgeSapkin avatar Dec 20 '25 12:12 GeorgeSapkin