knot-resolver: fix make config

[facboy]

• Fix errors in make config preventing e.g. menuconfig from working, and knot-resolver from being included in builds

Maintainer: @miska

Build system: x86/64 Compile tested: rockchip/armv8, nanopi-r4s, be37ab6e51 snapshot build Run tested: rockchip/armv8, nanopi-r4s, be37ab6e51 snapshot build, running on my main router

[facboy]

i forgot this required protobuf-c-compiler to be installed on Ubuntu, because it fixes the 'dnstap enabled by default' config so that it actually builds the dnstap module.

[facboy]

@autobakterie the build docker image doesn't seem to have protobuf-c-compiler installed by default, would it be simplest just to revert this to disable dnstap by default?

[neheb]

PKG_RELEASE bump is needed.

[facboy]

Thx fixed.

[Rondom]

Disabling the option because of the CI failure seems a bit suboptimal.

It seems to build fine on buildbot infra and I am not entirely sure, why it succeeds there and why not on GitHub CI. I have outlined how we could fix the missing-protobuf-compiler-issue without changing any defaults in the linked comment.

[BKPepe]

Disabling the option because of the CI failure seems a bit suboptimal.

This. Because of this, closing.

[Rondom]

The kconfig fix was good, though. On the other hand, once a host build has been added, maybe the binary size difference doesn't warrant keeping the config option, or, if there is a big difference in binary size, then we should build both packages (as variant)