packages icon indicating copy to clipboard operation
packages copied to clipboard

nginx: update init script to publish services over mdns

Open mhusaam opened this issue 1 year ago • 5 comments

update init script to announce http related services over mdns

Signed-off-by: Mohd Husaam Mehdi [email protected]

mhusaam avatar Mar 27 '24 16:03 mhusaam

please remove the merge commit @mhusaam

systemcrash avatar Apr 17 '24 01:04 systemcrash

Hi @systemcrash, thanks for pointing it out. I have updated the PR, kindly review.

mhusaam avatar Apr 18 '24 12:04 mhusaam

Hi @systemcrash, thanks for your comments. Kindly review. The following has been updated:

  1. mdns option moved to global main section instead of per server. (while revisiting I realised that we cannot add an option in server section.)
  2. changed mdns to default false, so now it has to be explicitly set to true. (because it was mentioned as a comment in my other PR: https://github.com/openwrt/packages/pull/23765#discussion_r1555399706)
  3. Resolved your comments.

Thanks.

mhusaam avatar Apr 19 '24 07:04 mhusaam

Otherwise, looks good functionality-wise.

systemcrash avatar Apr 20 '24 11:04 systemcrash

Hello @systemcrash, thanks for your comments. I have resolved them. Kindly review.

mhusaam avatar Apr 20 '24 15:04 mhusaam