packages
packages copied to clipboard
openwrt
proto-bonding: Modify ipaddr as optional
Maintainer: Helge Mader [email protected] Compile tested: x86_64, main Run tested: x86_64, main
Description: The configuration of ipaddr in proto-bonding is not necessary, such as adding the bond interface to the bridge or performing pppoe dialing on the bond interface, etc.
@findlayfeng Can you please add to your commit description, why this change is needed? At some point in the future, if you want to see why this has been changed, a good description would not be bad. Also please update the pullrequest description with correct values.
I prefer to rewrite the content of the bond interface into a bond device. Bond is more suitable as a device, but that seems to be a relatively large modification and destroys compatibility. The current modification is quite appropriate. It retains the compatibility of the old configuration and allows for more flexible use of the bond interface. In addition, I also submitted a PR on luci-proto-bonding to remove the ipaddr check.
@feckert Is this appropriate? My description in English requires the help of Google Translate
@findlayfeng I think that there was/is a limitation in netifd that requires static protocol interfaces to have an IP address unless they are virtual. That said, netifd support bonding devices since https://github.com/openwrt/netifd/commit/5ba9744aac6d42da1e56357aca951b52f86cfacb but luci does not.
I've implemented luci support in https://github.com/openwrt/luci/pull/7086
