packages icon indicating copy to clipboard operation
packages copied to clipboard

WIP: strongswan: change all dependencies on mod-socket-default to mod-socket

Open Thermi opened this issue 1 year ago • 5 comments

Maintainer: me (@thermi) / @pprindeville Compile tested: x86_64, master Run tested: x86_64, master

Description:

Fixes the bogus circular dependency issue seen in #16367

Thermi avatar Aug 16 '22 17:08 Thermi

In my test this change makes opkg select socket-dynamic and enables socket-default and socket-dynamic to provide strongswan-mod-socket. This also matches what I can see in the opkg output.

Thermi avatar Aug 16 '22 17:08 Thermi

@stintel please let me know if this works for you too

Thermi avatar Aug 16 '22 17:08 Thermi

This is WIP now because the solution works but we probably want to do it as part of a larger revamping of the expressed dependencies within the package to allow installing less packages if required and express the different possible providers for crypto within the strongSwan code in the Makefile to allow, for example, users to forego the strongswan-mod-aes package for the strongswan-mod-openssl package (because the openssl package though libopenssl already provides an AES implementation).

Thermi avatar Aug 16 '22 20:08 Thermi

@stintel please let me know if this works for you too

Not seeing circular dependencies with this one, thanks!

stintel avatar Aug 16 '22 22:08 stintel

@Thermi: Thanks!

Neustradamus avatar Aug 16 '22 23:08 Neustradamus

@Thermi Is this still WIP or is it ready to merge?

pprindeville avatar Sep 08 '22 03:09 pprindeville

Still wip

Am 8. September 2022 03:48:49 UTC schrieb Philip Prindeville @.>: @. Is this still WIP or is it ready to merge?

-- Reply to this email directly or view it on GitHub: https://github.com/openwrt/packages/pull/19184#issuecomment-1240183381 You are receiving this because you were mentioned.

Message ID: @.***> -- Sent from mobile. Please excuse any typos or brevity

Thermi avatar Sep 08 '22 06:09 Thermi

What's the status of this?

pprindeville avatar Apr 07 '23 18:04 pprindeville