packages icon indicating copy to clipboard operation
packages copied to clipboard

chore: Set permissions for GitHub actions

Open naveensrinivasan opened this issue 3 years ago • 3 comments

Restrict the GitHub token permissions only to the required ones; this way, even if the attackers will succeed in compromising your workflow, they won’t be able to do much.

  • Included permissions for the action. https://github.com/ossf/scorecard/blob/main/docs/checks.md#token-permissions

https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#permissions

https://docs.github.com/en/actions/using-jobs/assigning-permissions-to-jobs

Keeping your GitHub Actions and workflows secure Part 1: Preventing pwn requests

Signed-off-by: naveen [email protected]

naveensrinivasan avatar Jun 23 '22 00:06 naveensrinivasan

  • Test Formalities / Test Formalities (pull_request) fails for you. Would you mind to fix it?

BKPepe avatar Jun 29 '22 20:06 BKPepe

  • Test Formalities / Test Formalities (pull_request) fails for you. Would you mind to fix it?

Can I do that in a future PR? Thanks

naveensrinivasan avatar Jul 04 '22 22:07 naveensrinivasan

No. Signed-off-by is required to all commits, which we have in OpenWrt repositories.

BKPepe avatar Aug 13 '22 09:08 BKPepe

Kind reminder, or else I will close this pull request within a few days.

BKPepe avatar Oct 29 '22 03:10 BKPepe

Kind reminder, or else I will close this pull request within a few days.

I don't have time now. Apologies for not getting back sooner.

naveensrinivasan avatar Oct 29 '22 13:10 naveensrinivasan

And you have time for response, that's interesting because both things take the same amount of time.

Closing. If you will have time in the future, which I doubt (TBH), then re-open this pull request or create a new one.

BKPepe avatar Oct 30 '22 08:10 BKPepe