mediatek: add Comfast CF-E395AX support by adding an alternative model name
both these devices share the board and same config, just different model number
Install instructions are the same as the CF-E393AX commit - https://git.openwrt.org/?p=openwrt/openwrt.git;a=commit;h=d8f4453bf2de9fd9baf3d660ed12e0797ff2cfdb
@db260179: Good job!
What is the difference between the two devices?
What is the difference between the two devices?
Just the model number, reason for this common config - the chassis is literally the only difference - they cost reduced it, so the 393ax has a bigger case than the 395ax - the actual board is identical.
Do we really need an extra image and device tree? If it is just about the name you can add an alternative name:
--- a/target/linux/mediatek/image/filogic.mk
+++ b/target/linux/mediatek/image/filogic.mk
@@ -482,6 +482,8 @@ TARGET_DEVICES += cmcc_rax3000m
define Device/comfast_cf-e393ax
DEVICE_VENDOR := COMFAST
DEVICE_MODEL := CF-E393AX
+ DEVICE_ALT0_VENDOR := COMFAST
+ DEVICE_ALT0_MODEL := CF-E395AX
DEVICE_DTS := mt7981a-comfast-cf-e393ax
DEVICE_DTS_DIR := ../dts
DEVICE_DTC_FLAGS := --pad 4096
Do we really need an extra image and device tree? If it is just about the name you can add an alternative name:
--- a/target/linux/mediatek/image/filogic.mk +++ b/target/linux/mediatek/image/filogic.mk @@ -482,6 +482,8 @@ TARGET_DEVICES += cmcc_rax3000m define Device/comfast_cf-e393ax DEVICE_VENDOR := COMFAST DEVICE_MODEL := CF-E393AX + DEVICE_ALT0_VENDOR := COMFAST + DEVICE_ALT0_MODEL := CF-E395AX DEVICE_DTS := mt7981a-comfast-cf-e393ax DEVICE_DTS_DIR := ../dts DEVICE_DTC_FLAGS := --pad 4096
Yes makes sense, only issue the users might not know that this image will work on the e395ax, but i have changed the commit to your recommended change.
merged, Thanks !
@blogic: Are you sure?
I do not see here:
- https://github.com/openwrt/openwrt/blob/main/target/linux/mediatek/image/filogic.mk
its still in my local staging, will push during the day
Merged commit:
- https://github.com/openwrt/openwrt/commit/794291bbdf26ad2be7581fc0c921e4d820937c79