openwrt icon indicating copy to clipboard operation
openwrt copied to clipboard

realtek: add support for HPE 1920-48G (JG927A) and 1920-48G-PoE (JG928A)

Open howels opened this issue 1 year ago • 8 comments

Hardware information:

  • SoC: RTL8393M
  • Copper phy: 6×RTL8218B
  • Fibre phy: RTL8214FC
  • Flash: 32MiB SPI NOR, MX25L25635FMI
  • RAM: 128MiB DDR3, Micron MT41K64M16TW-107
  • Serial port: ±5V serial port to RJ45, ZT3232 (MAX3232 compatible)
  • +370W POE on JG928A model

Installation:

howels avatar Jun 20 '24 14:06 howels

I would add a note to the commit message that the SFP ports do not work due to missing support for the RTL8214FC on the RTL8393M target.

andyboeh avatar Jun 20 '24 19:06 andyboeh

RTL8214FC on the RTL8393M target.

Added a note to address that.

howels avatar Jun 20 '24 20:06 howels

I have tested it on my JG927A and can confirm it works on current main branch (except for the SFP ports as expected).

Thank you for opening the pull request!

janh avatar Jun 20 '24 22:06 janh

Updating to set Andreas in the commit sign-off.

howels avatar Jun 21 '24 12:06 howels

@svanheule please can you review this addition for the HPE 48 port 1920 switch.

howels avatar Jun 24 '24 22:06 howels

Updated to set POE UCI values on ports 1-48 and add realtek PoE package for PoE model.

howels avatar Jun 25 '24 21:06 howels

Updated i2c 2 and 3, as well as adding my own details to the commit and updating the sign-off.

howels avatar Jul 01 '24 12:07 howels

The commit message has: GPIO: 3×RTL8231, 3×SN74LVC08A

But I don't see these anywhere in the devicetree. Am I missing something?

Also, if you're making changes to someone else's patches, you need to add your own Signed-off-by preceded by a list/description of the changes you made.

Updated as per your comments, the hardware info is actually taken from your excellent switch hardware website but if the GPIO is not relevant then I will omit that portion.

howels avatar Jul 02 '24 15:07 howels

Is anyone else able to review this please? Would help complete the HPE 1920 family of switches. Thanks for your time.

howels avatar Jul 05 '24 15:07 howels

I've built and run-tested a JG927A. WORKSFORME.

Take your pick:

~~Signed-off-by: Martin Kennedy [email protected]~~

Retracted, pending solving some of the status LED nonsense below. I have hardware on order to test.

Hurricos avatar Jul 09 '24 06:07 Hurricos

I've built and run-tested a JG927A. WORKSFORME.

Take your pick:

Acked-by: Martin Kennedy [email protected]

Signed-off-by: Martin Kennedy [email protected]

Thanks for testing - appreciated.

howels avatar Jul 09 '24 11:07 howels

Please can Realtek maintainers check this PR.

howels avatar Jul 15 '24 19:07 howels

FYI the PoE port map (/etc/config/poe) for JG928A is as follows:

config global
        option budget   '385'

config port
        option enable   '1'
        option id       '1'
        option name     'lan8'
        option poe_plus '1'
        option priority '2'

config port
        option enable   '1'
        option id       '2'
        option name     'lan7'
        option poe_plus '1'
        option priority '2'

config port
        option enable   '1'
        option id       '3'
        option name     'lan6'
        option poe_plus '1'
        option priority '2'

config port
        option enable   '1'
        option id       '4'
        option name     'lan5'
        option poe_plus '1'
        option priority '2'

config port
        option enable   '1'
        option id       '5'
        option name     'lan4'
        option poe_plus '1'
        option priority '2'

config port
        option enable   '1'
        option id       '6'
        option name     'lan3'
        option poe_plus '1'
        option priority '2'

config port
        option enable   '1'
        option id       '7'
        option name     'lan2'
        option poe_plus '1'
        option priority '2'

config port
        option enable   '1'
        option id       '8'
        option name     'lan1'
        option poe_plus '1'
        option priority '2'

config port
        option enable   '1'
        option id       '9'
        option name     'lan16'
        option poe_plus '1'
        option priority '2'

config port
        option enable   '1'
        option id       '10'
        option name     'lan15'
        option poe_plus '1'
        option priority '2'

config port
        option enable   '1'
        option id       '11'
        option name     'lan14'
        option poe_plus '1'
        option priority '2'

config port
        option enable   '1'
        option id       '12'
        option name     'lan13'
        option poe_plus '1'
        option priority '2'

config port
        option enable   '1'
        option id       '13'
        option name     'lan12'
        option poe_plus '1'
        option priority '2'

config port
        option enable   '1'
        option id       '14'
        option name     'lan11'
        option poe_plus '1'
        option priority '2'

config port
        option enable   '1'
        option id       '15'
        option name     'lan10'
        option poe_plus '1'
        option priority '2'

config port
        option enable   '1'
        option id       '16'
        option name     'lan9'
        option poe_plus '1'
        option priority '2'

config port
        option enable   '1'
        option id       '17'
        option name     'lan24'
        option poe_plus '1'
        option priority '2'

config port
        option enable   '1'
        option id       '18'
        option name     'lan23'
        option poe_plus '1'
        option priority '2'

config port
        option enable   '1'
        option id       '19'
        option name     'lan22'
        option poe_plus '1'
        option priority '2'

config port
        option enable   '1'
        option id       '20'
        option name     'lan21'
        option poe_plus '1'
        option priority '2'

config port
        option enable   '1'
        option id       '21'
        option name     'lan20'
        option poe_plus '1'
        option priority '2'

config port
        option enable   '1'
        option id       '22'
        option name     'lan19'
        option poe_plus '1'
        option priority '2'

config port
        option enable   '1'
        option id       '23'
        option name     'lan18'
        option poe_plus '1'
        option priority '2'

config port
        option enable   '1'
        option id       '24'
        option name     'lan17'
        option poe_plus '1'
        option priority '2'

config port
        option enable   '1'
        option id       '25'
        option name     'lan32'
        option poe_plus '1'
        option priority '2'

config port
        option enable   '1'
        option id       '26'
        option name     'lan31'
        option poe_plus '1'
        option priority '2'

config port
        option enable   '1'
        option id       '27'
        option name     'lan30'
        option poe_plus '1'
        option priority '2'

config port
        option enable   '1'
        option id       '28'
        option name     'lan29'
        option poe_plus '1'
        option priority '2'

config port
        option enable   '1'
        option id       '29'
        option name     'lan28'
        option poe_plus '1'
        option priority '2'

config port
        option enable   '1'
        option id       '30'
        option name     'lan27'
        option poe_plus '1'
        option priority '2'

config port
        option enable   '1'
        option id       '31'
        option name     'lan26'
        option poe_plus '1'
        option priority '2'

config port
        option enable   '1'
        option id       '32'
        option name     'lan25'
        option poe_plus '1'
        option priority '2'

config port
        option enable   '1'
        option id       '33'
        option name     'lan40'
        option poe_plus '1'
        option priority '2'

config port
        option enable   '1'
        option id       '34'
        option name     'lan39'
        option poe_plus '1'
        option priority '2'

config port
        option enable   '1'
        option id       '35'
        option name     'lan38'
        option poe_plus '1'
        option priority '2'

config port
        option enable   '1'
        option id       '36'
        option name     'lan37'
        option poe_plus '1'
        option priority '2'

config port
        option enable   '1'
        option id       '37'
        option name     'lan36'
        option poe_plus '1'
        option priority '2'

config port
        option enable   '1'
        option id       '38'
        option name     'lan35'
        option poe_plus '1'
        option priority '2'

config port
        option enable   '1'
        option id       '39'
        option name     'lan34'
        option poe_plus '1'
        option priority '2'

config port
        option enable   '1'
        option id       '40'
        option name     'lan33'
        option poe_plus '1'
        option priority '2'

config port
        option enable   '1'
        option id       '41'
        option name     'lan48'
        option poe_plus '1'
        option priority '2'

config port
        option enable   '1'
        option id       '42'
        option name     'lan47'
        option poe_plus '1'
        option priority '2'

config port
        option enable   '1'
        option id       '43'
        option name     'lan46'
        option poe_plus '1'
        option priority '2'

config port
        option enable   '1'
        option id       '44'
        option name     'lan45'
        option poe_plus '1'
        option priority '2'

config port
        option enable   '1'
        option id       '45'
        option name     'lan44'
        option poe_plus '1'
        option priority '2'

config port
        option enable   '1'
        option id       '46'
        option name     'lan43'
        option poe_plus '1'
        option priority '2'

config port
        option enable   '1'
        option id       '47'
        option name     'lan42'
        option poe_plus '1'
        option priority '2'

config port
        option enable   '1'
        option id       '48'
        option name     'lan41'
        option poe_plus '1'
        option priority '2'

howels avatar Aug 02 '24 14:08 howels

Updated to reflect the new Realtek target structure following move towards 6.6 kernel.

howels avatar Sep 15 '24 16:09 howels

I see the kernel config changes disappeared with the rebase. Is that intentional?

svanheule avatar Sep 15 '24 17:09 svanheule

I see the kernel config changes disappeared with the rebase. Is that intentional?

I checked the default config and thought they were included. Looks like I might have made a mistake, config changes are now added for both 6.6 and 5.15.

howels avatar Sep 15 '24 21:09 howels

Thanks for the update! Merged to main with 732f539fb757f96137149617a79a0a56f737ac1f

svanheule avatar Sep 17 '24 19:09 svanheule