Fix null pointer access in proxy_set

Open arodland opened this issue 2 years ago • 2 comments

We were checking proxy->ifindex, but proxy is initialized to NULL. Should be checking p->ifindex instead.

This fix was proposed by user @jajik in https://github.com/openwrt/omcproxy/issues/2 in 2017, but never adopted. I'm making a PR in hopes that it gets seen.

Oct 10 '23 17:10 arodland

I built this and tested it on my openwrt, and it does fix the segfault on startup.

Oct 12 '23 16:10 arodland

Yes, we used it with the proposed fix since 2017 and I've not heard about any error since then.

close #2

Oct 12 '23 16:10 jajik