[24.10] luci-mod-network: Solve the problem of no address assignment with multiple interfaces enabled for DHCP
Due to missing configuration options, when the DHCP service is enabled on multiple interfaces, it cannot assign addresses to clients under specific conditions. These options are now being added to resolve the issue.
- [ ] This PR is not from my main or master branch :poop:, but a separate branch :white_check_mark:
- [ ] Each commit has a valid :black_nib:
Signed-off-by: <[email protected]>row (viagit commit --signoff) - [ ] Each commit and PR title has a valid :memo:
<package name>: titlefirst line subject for packages - [ ] Incremented :up: any
PKG_VERSIONin the Makefile - [ ] Tested on: (architecture, openwrt version, browser) :white_check_mark:
- [ ] ( Preferred ) Mention: @ the original code author for feedback
- [ ] ( Preferred ) Screenshot or mp4 of changes:
- [ ] ( Optional ) Closes: e.g. openwrt/luci#issue-number
- [ ] ( Optional ) Depends on: e.g. openwrt/packages#pr-number in sister repo
- [ ] Description: (describe the changes proposed in this PR)
This is only relevant if you're using odhcpd as your DHCPv4 server, right?
And I should add that this has been fixed in master: https://github.com/openwrt/luci/blob/7df4840b1c077acef60a6a00e8477f686c22b882/modules/luci-mod-network/htdocs/luci-static/resources/view/network/interfaces.js#L694
This is only relevant if you're using
odhcpdas your DHCPv4 server, right?And I should add that this has been fixed in
master:
Yes, the issue has already been fixed in the master branch, and all non-master branches have this problem.
Unfortunately, except for 24.10 branch, the other branches are no longer maintained.
[!WARNING]
Some formality checks failed.
Consider (re)reading submissions guidelines.
Failed checks
Issues marked with an :x: are failing checks.
Commit 72c770b4b4b781cd663e3a2107fe57de8ea6b87d
- :x: First word after prefix in subject should not be capitalized
- :x: Commit subject length: recommended max 50, required max 60 characters
- :large_orange_diamond: Commit body line 1 is longer than 75 characters (is 215): Due to missing configuration options, when the DHCP service is enabled on multiple interfaces, it cannot assign addresses to clients under specific conditions. These options are now being added to resolve the issue.
- :large_orange_diamond: Commit tog stable branch
openwrt-24.10should be cherry-picked
For more details, see the full job log.
Something broken? Consider providing feedback.
Please cherry pick from master.