luci icon indicating copy to clipboard operation
luci copied to clipboard

luci-base: Correct how textarea's wrap works

Open morytyann opened this issue 1 year ago • 2 comments

  • [x] This PR is not from my main or master branch :poop:, but a separate branch :white_check_mark:
  • [x] Each commit has a valid :black_nib: Signed-off-by: <[email protected]> row (via git commit --signoff)
  • [x] Each commit and PR title has a valid :memo: <package name>: title first line subject for packages
  • [ ] Incremented :up: any PKG_VERSION in the Makefile
  • [x] Tested on: (aarch64_cortex-a53/x86, OpenWrt23.05.3, Chrome/Edge/Vivaldi) :white_check_mark:
  • [ ] ( Preferred ) Mention: @ the original code author for feedback
  • [ ] ( Preferred ) Screenshot or mp4 of changes:
  • [ ] ( Optional ) Closes: e.g. openwrt/luci#issue-number
  • [ ] ( Optional ) Depends on: e.g. openwrt/packages#pr-number in sister repo
  • [x] Description: (describe the changes proposed in this PR)

Currently the wrap flag of textarea doesn't works properly, this PR fix it. Reference

morytyann avatar Jul 05 '24 09:07 morytyann

@dannil @stokito I thought you might have a better understanding about this than I have.

systemcrash avatar Jul 05 '24 23:07 systemcrash

@morytyann please update your commit and initial PR message once done

systemcrash avatar Jul 05 '24 23:07 systemcrash

According to MDN, off is a non-standard solution so we should at least not use that one if possible if we're fixing the wrap behavior anyway.

dannil avatar Jul 06 '24 07:07 dannil

@dannil I checked and it works fine in both Chrome and FF:

https://codepen.io/pcgeek86/pen/ywgWRb

stokito avatar Jul 06 '24 07:07 stokito

@dannil I checked and it works fine in both Chrome and FF:

https://codepen.io/pcgeek86/pen/ywgWRb

Nice, then it should be fine to merge it.

dannil avatar Jul 06 '24 07:07 dannil

Ok, thank you @dannil and @stokito!

systemcrash avatar Jul 06 '24 11:07 systemcrash

Thanks @morytyann.

systemcrash avatar Jul 06 '24 11:07 systemcrash