luci icon indicating copy to clipboard operation
luci copied to clipboard

luci-mod-status: Move "Scroll to tail" button to header line on syslog and kernellog status pages

Open CharlesMengCA opened this issue 1 year ago • 7 comments

Layout after the changes.

Button

CharlesMengCA avatar Mar 20 '24 01:03 CharlesMengCA

Hello! Thank you for this PR.

Would you like to move the button for aesthetic reasons? Balance?

I think I will NACK this for a few reasons:

  • for the majority L-to-R readers it's an extra eye-scan to read the button content from the header text.
  • You now have to move the mouse quite far - some extra mileage, especially when you might actually need to swap between the kernel and system logs. More exercise than necessary :)

systemcrash avatar Mar 20 '24 08:03 systemcrash

Just look at the github headers, you will see it is very common to put the header and buttons on the same row.

Capture

This way will save some space on vertical direction. Normally most of monitors are 4:3, 16:9 or even wider, the vertical space is kind of tight and shouldn't be wasted.

Most the time, when I am on the log page, I will use the mouse wheel to scroll down the log to see if there is an error or warning.

Moving the button away will give me more view area at the beginning.

CharlesMengCA avatar Mar 21 '24 04:03 CharlesMengCA

  • You now have to move the mouse quite far - some extra mileage, especially when you might actually need to swap between the kernel and system logs. More exercise than necessary :)

I also like the current layout, indeed, if i need to skip between kernel and syslog then i dont need move my mouse too much.

Most the time, when I am on the log page, I will use the mouse wheel to scroll down the log to see if there is an error or warning.

Moving the button away will give me more view area at the beginning.

That kind of kills the argument about the viewing space, you can just use the scroll wheel to move the button off the screen.

Ramon00 avatar Mar 31 '24 19:03 Ramon00

Moved button beside the header.

Just don't like two separated lines for a short header and a single button.

Button

CharlesMengCA avatar Apr 04 '24 03:04 CharlesMengCA

@Ramon00 - updated. Good?

systemcrash avatar Apr 09 '24 12:04 systemcrash

@systemcrash I think its a good compromise!

Ramon00 avatar Apr 09 '24 16:04 Ramon00

What's next? just waiting for the approval? :)

CharlesMengCA avatar Apr 16 '24 02:04 CharlesMengCA