luci icon indicating copy to clipboard operation
luci copied to clipboard

dnsmasq: Add options for new EDNS0 options

Open schuettecarsten opened this issue 1 year ago • 4 comments

The pull request https://github.com/openwrt/openwrt/pull/14349 adds four new options to configure EDNS0 upstream support. This patch adds the new settings to DNSMASQ web UI.

image

schuettecarsten avatar Mar 07 '24 16:03 schuettecarsten

Please don't change the indentation of the files, it makes the diff impossible to review.

dannil avatar Mar 07 '24 17:03 dannil

Please don't change the indentation of the files, it makes the diff impossible to review.

Oh, sorry, I've set Fork to ignore tabs/spaces, so I did not see that. Unfortunately, some js fils use tabs, some use spaces, so it's difficult to choose the correct editor setting and make sure that it does not change indentation on save. Force-pushed....

schuettecarsten avatar Mar 07 '24 17:03 schuettecarsten

Please don't change the indentation of the files, it makes the diff impossible to review.

Oh, sorry, I've set Fork to ignore tabs/spaces, so I did not see that. Unfortunately, some js fils use tabs, some use spaces, so it's difficult to choose the correct editor setting and make sure that it does not change indentation on save. Force-pushed....

If you have a modern editor there's usually functionality to dynamically learn to use tab or spaces (and the amount of spaces) for the tab character depending on the rest of the content of the file, so no need to manually configure it (VSCode for example), but yeah entirely depends on your editor.

dannil avatar Mar 07 '24 17:03 dannil

Please don't change the indentation of the files, it makes the diff impossible to review.

Oh, sorry, I've set Fork to ignore tabs/spaces, so I did not see that. Unfortunately, some js fils use tabs, some use spaces, so it's difficult to choose the correct editor setting and make sure that it does not change indentation on save. Force-pushed....

If you have a modern editor there's usually functionality to dynamically learn to use tab or spaces (and the amount of spaces) for the tab character depending on the rest of the content of the file, so no need to manually configure it (VSCode for example), but yeah entirely depends on your editor.

It was VSCode detecting mixed indent and deciding to reformat the whole file. :-D

schuettecarsten avatar Mar 07 '24 18:03 schuettecarsten

Will be replaced by updated version

schuettecarsten avatar Jul 17 '24 19:07 schuettecarsten