luci-mod-network : Cipher option is not required for WPA3 Enterprise …
…encryption
- [ ] This PR is not from my main or master branch :poop:, but a separate branch :white_check_mark:
- [ ] Each commit has a valid :black_nib:
Signed-off-by: <[email protected]>row (viagit commit --signoff) - [ ] Each commit and PR title has a valid :memo:
<package name>: titlefirst line subject for packages - [ ] Incremented :up: any
PKG_VERSIONin the Makefile - [ ] Tested on: (architecture, openwrt version, browser) :white_check_mark:
- [ ] ( Preferred ) Mention: @ the original code author for feedback
- [ ] ( Preferred ) Screenshot or mp4 of changes:
- [ ] ( Optional ) Closes: e.g. openwrt/luci#issue-number
- [ ] ( Optional ) Depends on: e.g. openwrt/packages#pr-number in sister repo
- [ ] Description: (describe the changes proposed in this PR)
This needs more context. Is that setting optional or must it strictly not be present with WPA3 enterprise mode? Does it prevent hostapd startup? Is this fixing an actual bug, if so which one?
We should probably not just hide the Cipher option, a more appropriate solution in my mind is to modify the selectable ciphers to only contain auto and CCMP when WPA3 is selected (or maybe even remove auto as well since CCMP is the only valid option).
@morse-sophronia would you like to continue or close this PR? WPA3 can have multiple ciphers...
I confirm no TKIP for WPA3:
- WPA3 Personal -> Simultaneous Authentication of Equals (SAE) with forward secrecy (FS/PFS) -> GCMP - AES
- WPA3 Enterprise -> 802.1X/EAP -> GCMP - AES
It must be solved.
Ticket:
- https://github.com/openwrt/luci/issues/6962