luci luci-app-example: improve description

luci-app-example: improve description

Open stokito opened this issue 2 years ago • 2 comments

I spent for some time while figured out how to start the example app. Please accept the PR that improves README

Jul 31 '22 10:07 stokito

@andibraeu could you please review and merge this? The small change may save a lot of time for newcomers

Aug 19 '22 06:08 stokito

I don't have rights to merge PRs here.

One note: you don't need to execute the file in uci-defaults. I think after a reboot it should be fine, too.

Aug 19 '22 11:08 andibraeu

That extra ssh chmod command is not needed since uci-defaults scripts are sourced, not executed.

Oct 13 '22 11:10 jow-

ok, can you merge and remove it? because I don't have a time now to fix this

Oct 13 '22 11:10 stokito

Unfortunately I also only had a few minutes to spare to glance over PRs. I am not on a machine right now where I can do Git operations.

Oct 13 '22 11:10 jow-

Ok I cloned and replaced that line with:

ssh [email protected] "sh /etc/uci-defaults/80_example"

E.g. the script will be executed with shell but not marked as executable. I checked and it works

Oct 13 '22 11:10 stokito

Great, thanks!

Oct 13 '22 11:10 jow-