luci icon indicating copy to clipboard operation
luci copied to clipboard

luci-app-zerotier: add a new luci app to manage zerotier vpn

Open andrewc12 opened this issue 3 years ago • 16 comments

Based on https://github.com/coolsnowwolf/lede/tree/master/package/lean/luci-app-zerotier

  • without the interface code and scripts for allowing NAT access to the local LAN.
  • added missing btn class to Zerotier.com button which fixes button style in the openwrt2020 theme.
  • removed html from Zerotier.com button translation.
  • add es translation and template from https://github.com/openwrtdiy/openwrt-ipk/tree/main/luci-app-zerotier
  • regenerated translation template from source
  • normalised translation files
  • add luci-compat to package dependencies

Signed-off-by: Andrew Innes [email protected]

andrewc12 avatar Feb 01 '22 04:02 andrewc12

This doesn't work on a fresh install. I found out I need to install luci-compat (as per https://forum.openwrt.org/t/luci-app-bird1-ipv4-errors/70288 ) to get it to work

andrewc12 avatar Feb 02 '22 12:02 andrewc12

fixed and package successfully tested in a new vm

andrewc12 avatar Feb 02 '22 15:02 andrewc12

I doubt they'll accept this PR if it's not in JavaScript.

castillofrancodamian avatar Feb 02 '22 16:02 castillofrancodamian

I only found out about that transition at the end. I was going to try to write something myself but then I found this, so I decided try to get it upstreamed instead. I'll have to actually put work in.

andrewc12 avatar Feb 02 '22 17:02 andrewc12

It seems that this pull request can be closed for now and once it will be converted to the JavaScript, it can be reopened, right?

BKPepe avatar Mar 05 '23 08:03 BKPepe

sure but I'm not going to do that.

andrewc12 avatar Mar 05 '23 08:03 andrewc12

Is this still going on? Because I saw that there was the same package in Immortalwrt and it already used JavaScript.

CC @1715173329

animegasan avatar Feb 05 '24 09:02 animegasan

Nah it's closed. I might take a look at that though

https://github.com/immortalwrt/luci/tree/master/applications/luci-app-zerotier

andrewc12 avatar Feb 05 '24 09:02 andrewc12

Nah it's closed. I might take a look at that though

https://github.com/immortalwrt/luci/tree/master/applications/luci-app-zerotier

So is there any possibility that this package is in openwrt?

animegasan avatar Feb 05 '24 09:02 animegasan

I went through and collected/rewrote the history of this app from the following three repos https://github.com/coolsnowwolf/lede/commits/cc9ce1dbb53b58c66fd5e72e6ec7a5e7428d91d2/package/lean/luci-app-zerotier https://github.com/1715173329/imoutowrt/commits/aa3fa0df3cb49af67adbd3ec792422815d482fa1/package/lean/luci-app-zerotier https://github.com/immortalwrt/luci/commits/master/applications/luci-app-zerotier

@animegasan I'm going to try to get this merged. It's been so long I don't remember how to do this though. Are you able to test this out in the meantime?

andrewc12 avatar Feb 09 '24 02:02 andrewc12

As this is introduction of a new app, you should git squash the 44 commits into one.

hnyman avatar Feb 09 '24 07:02 hnyman

I'm planning on it

andrewc12 avatar Feb 09 '24 08:02 andrewc12

@1715173329 do you want to take a look?

andrewc12 avatar Feb 09 '24 08:02 andrewc12

@systemcrash Thanks for the suggestions. I'm soon starting university again so I might not get to it for a couple of months

andrewc12 avatar Feb 11 '24 20:02 andrewc12