luci icon indicating copy to clipboard operation
luci copied to clipboard

luci-mod-network: Expose multicast_to_unicast setting

Open systemcrash opened this issue 4 years ago • 4 comments

Tested on: 21.02.1

Signed-off-by: Paul Dee [email protected]

systemcrash avatar Dec 08 '21 01:12 systemcrash

@systemcrash can you improve the commit description ? also remove the (wireless) tag?

Ansuel avatar Feb 22 '22 14:02 Ansuel

What would constitute an "improvement"? The commit itself is only 4 lines.

systemcrash avatar Feb 22 '22 14:02 systemcrash

A commit description is mandatory in 99% of the commits... Something like

luci-mod-network: expose multicast_to_unicast wireless setting

From https://w1.fi/cgit/hostap/commit/?id=34f7c699a6bcb5c45f82ceb6743354ad79296078
add support for multicast_to_unicast conversion in the wireless settings. 

Ansuel avatar Feb 22 '22 15:02 Ansuel

A commit description is mandatory in 99% of the commits... Something like

OK thanks - I just didn't want it to stray too far from being short and concise.

systemcrash avatar Feb 22 '22 15:02 systemcrash

Ready for merge.

systemcrash avatar Aug 30 '22 16:08 systemcrash