asu icon indicating copy to clipboard operation
asu copied to clipboard

build: eliminate kill of already stopped containers

Open efahl opened this issue 1 month ago • 3 comments

Some error paths result in the container.kill being called twice. This results in an erroneous error report to the user, with the podman error superseding the actual build error in the message output:

409 Client Error: Conflict (can only kill running containers...

Fix it by removing the extra calls.

efahl avatar Oct 31 '25 19:10 efahl

@aparcar I found this one by scanning my log output from https://github.com/openwrt/asu/pull/1522 running on my local server. It would be nice to get 1522 in, too, so I can see more of what's going on with the 3-400 errors/day on the production server...

efahl avatar Oct 31 '25 19:10 efahl

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 92.40%. Comparing base (5e65dec) to head (042c737). :warning: Report is 315 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1529       +/-   ##
===========================================
+ Coverage   80.75%   92.40%   +11.64%     
===========================================
  Files          15       15               
  Lines         977     1382      +405     
===========================================
+ Hits          789     1277      +488     
+ Misses        188      105       -83     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Oct 31 '25 19:10 codecov[bot]

See https://github.com/openwrt/asu/issues/1530 as an example...

efahl avatar Nov 02 '25 17:11 efahl

@aparcar Can we get this bug fix in, too? It's causing me headaches with trying to figure out root cause of issues due to it masking real errors.

efahl avatar Dec 16 '25 22:12 efahl

Thanks!

efahl avatar Dec 16 '25 22:12 efahl

Deployed

aparcar avatar Dec 17 '25 10:12 aparcar