OpenWPM icon indicating copy to clipboard operation
OpenWPM copied to clipboard

Consider logging return value of function call

Open vringar opened this issue 4 years ago • 1 comments

We currently log a call before we call the function. https://github.com/openwpm/OpenWPM/blob/771b6db4169374a7f7b6eb5ce6e59ea763f26df4/Extension/webext-instrumentation/src/lib/js-instruments.ts#L442-L451 This results in us being unable to capture the return value so we leave it empty. https://github.com/openwpm/OpenWPM/blob/771b6db4169374a7f7b6eb5ce6e59ea763f26df4/Extension/webext-instrumentation/src/lib/js-instruments.ts#L297-L309 Is there a reason we chose to do that?

vringar avatar Jan 16 '22 13:01 vringar

Hi,

I am trying to capture the return value of some functions myself. For what I saw, value is used for return of get() operations, but not for call() ones, but is used as "arg" for set() ones, which makes its usage a bit confusing. immagine

From SQLite Documentation I see that MAX_LENGTH for String is 1 billion bytes. Maybe is related to a size problem? Although it can be stored and I cannot anticipate a return value of over 1 billion bytes, maybe storing this information would inflate the DB too much...?

Giblin91 avatar Mar 24 '23 21:03 Giblin91