Added javascript option asyncstack

[Ayushsunny]

Added Set javascript.options.asyncstack to true in the function def optimize_prefs(prefs: Dict[str, Any]) -> None: Closes #678

[codecov[bot]]

Codecov Report

Merging #910 (b483048) into master (18e1286) will decrease coverage by 0.16%. The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #910      +/-   ##
==========================================
- Coverage   51.17%   51.01%   -0.17%     
==========================================
  Files          34       34              
  Lines        3392     3399       +7     
==========================================
- Hits         1736     1734       -2     
- Misses       1656     1665       +9     

Impacted Files	Coverage Δ
openwpm/deploy_browsers/configure_firefox.py	8.69% <0.00%> (-0.08%)	:arrow_down:
openwpm/browser_manager.py	71.54% <0.00%> (-1.39%)	:arrow_down:
openwpm/deploy_browsers/deploy_firefox.py	23.07% <0.00%> (-1.10%)	:arrow_down:
openwpm/config.py	95.83% <0.00%> (-0.84%)	:arrow_down:
openwpm/mp_logger.py	67.27% <0.00%> (+0.19%)	:arrow_up:
openwpm/task_manager.py	78.37% <0.00%> (+0.40%)	:arrow_up:

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 18e1286...b483048. Read the comment docs.

[vringar]

Do you want to try and also create a test page that uses setTimeout and assert that we now capture the full callstack as was asked in the last line of the original issue?

[Ayushsunny]

Do you want to try and also create a test page that uses setTimeout and assert that we now capture the full callstack as was asked in the last line of the original issue?

Hello @vringar I know lil bit about setTimeout function but I have no idea how we are gonna implement here. can you help me with that sir?

[vringar]

Hey, please create a HTML page under test/test_pages and create an inline script that uses set timeout before printing to console. I'll explain further once this is done.

[Ayushsunny]

Hey, please create a HTML page under test/test_pages and create an inline script that uses set timeout before printing to console. I'll explain further once this is done.

Hello @vringar , So we need something like this ?

[vringar]

Hey, I have underestimated the complexity of writing a test for this pref and don't have the time to mentor you on this any further. I'm sorry about that! Would it be okay for you to switch to something like #915 or #916 and leave this PR open for a while?

[Ayushsunny]

Hey, I have underestimated the complexity of writing a test for this pref and don't have the time to mentor you on this any further. I'm sorry about that! Would it be okay for you to switch to something like #915 or #916 and leave this PR open for a while?

Okay Sir, Sure.