OpenWPM icon indicating copy to clipboard operation
OpenWPM copied to clipboard

feat(browser_manager): enable full XPI cleanup

Open vringar opened this issue 1 year ago • 3 comments

vringar avatar Aug 07 '24 14:08 vringar

Codecov Report

Attention: Patch coverage is 57.14286% with 9 lines in your changes missing coverage. Please review.

Project coverage is 38.55%. Comparing base (dedc84b) to head (295eaa8). Report is 8 commits behind head on master.

Files with missing lines Patch % Lines
openwpm/browser_manager.py 58.82% 7 Missing :warning:
openwpm/deploy_browsers/deploy_firefox.py 0.00% 2 Missing :warning:

:exclamation: There is a different number of reports uploaded between BASE (dedc84b) and HEAD (295eaa8). Click for more details.

HEAD has 15 uploads less than BASE
Flag BASE (dedc84b) HEAD (295eaa8)
17 2
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1104      +/-   ##
==========================================
- Coverage   45.64%   38.55%   -7.09%     
==========================================
  Files          35       35              
  Lines        3475     3496      +21     
==========================================
- Hits         1586     1348     -238     
- Misses       1889     2148     +259     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Aug 07 '24 17:08 codecov[bot]

Do you need me to do anything more on this? I'm not well versed in CI/Codecov/etc., so I'm not sure where things stand based on what I see here.

ndanner-wesleyancs avatar Aug 09 '24 20:08 ndanner-wesleyancs

I haven't fully figured out what is causing these but I've also been focusing on #1103 I don't think you need to do anything else here

vringar avatar Aug 10 '24 10:08 vringar