openwrt-openwisp-monitoring
openwrt-openwisp-monitoring copied to clipboard
openwisp
OpenWRT monitoring agent for openwisp-monitoring
Up to now only the modem manager is supported to get information from them wwan modem. Not all system does have a modem manager instance running. There are the following...
The `logger` shell call is used over and over again. Which makes the code confusing. I would suggest that you move the call to a subroutine. https://github.com/openwisp/openwrt-openwisp-monitoring/blob/master/openwrt-openwisp-monitoring/files/monitoring.init https://github.com/openwisp/openwrt-openwisp-monitoring/blob/master/openwrt-openwisp-monitoring/files/monitoring.agent
Hey, Just letting you know, we are changing this from `device` to `ctl_device` upstream in the OpenWrt ModemManager protocol handler because of compatibility issues with DSA. I will link the...
It would be good to create a utility function which does the read, close and returning of the output when using io.popen(). This would also ensure that whoever will put...
Since we have already added a functionality to upload packages directly to downloads.openwisp.io, it will be beneficial to also upload checksums for built packages. This way users will be able...
> > Yes, I remove `-t` flag when logging in verbose mode. In verbose_mode, it is automatically tagging the logged message by the procd service name and if I pass...
I am not sure but there should be some ways to write unittests for monitoring agent or monitoring daemon too. We can research about the possibilities and try to cover...
This change was requested here: :point_down: https://github.com/openwisp/openwrt-openwisp-monitoring/pull/25#issuecomment-846430520 >In general I would split the netjson into small plugin parts. The problem I see here is that not all have all related...
Related to https://github.com/openwisp/openwisp-docs/issues/107. These documents are pulled by the logic being worked on in https://github.com/openwisp/openwisp-docs/pull/189. We are doing similar changes in all modules.
## Checklist - [x] I have read the [OpenWISP Contributing Guidelines](http://openwisp.io/docs/developer/contributing.html). - [x] I have manually tested the changes proposed in this pull request. - [ ] I have written...