openwisp-radius icon indicating copy to clipboard operation
openwisp-radius copied to clipboard
verified publisher icon openwisp

Issues/525 fix management command inconsistency

Open kaushikaryan04 opened this issue 1 year ago • 3 comments

As mentioned in the issue I have changed the delete_old_radiusbatch_users argument to take in days instead of months and have changed the tasks and tests accordingly.

kaushikaryan04 avatar Jun 30 '24 11:06 kaushikaryan04

Coverage Status

coverage: 98.678%. remained the same when pulling 5283833a58e20da58bc04919e5ca5b6b99d0274c on kaushikaryan04:issues/525-fix-management-command-inconsistency into 3303ae169fa214db6ffc3ca9fc6626fd6892dbc8 on openwisp:master.

coveralls avatar Jul 05 '24 17:07 coveralls

I think this should be good. All old features are working as they were before and --older-than-days is added as well. Documentation also updated.

kaushikaryan04 avatar Jul 09 '24 14:07 kaushikaryan04

Coverage Status

coverage: 98.647% (+0.002%) from 98.645% when pulling 24430042a9b4f7dd3db10aef864ba934bf63d4c9 on kaushikaryan04:issues/525-fix-management-command-inconsistency into dc8580f94bba8da857551d34d523564331f9633f on openwisp:master.

coveralls avatar Jul 09 '24 20:07 coveralls

Follw up:

https://github.com/openwisp/ansible-openwisp2/issues/500 https://github.com/openwisp/docker-openwisp/issues/392

nemesifier avatar Nov 21 '24 19:11 nemesifier