openwisp-network-topology icon indicating copy to clipboard operation
openwisp-network-topology copied to clipboard

[change] Integrate latest version of netjsongraph.js #149

Open totallynotvaishnav opened this issue 2 years ago • 4 comments

To do

  • [x] Improve date picker UI
  • [x] Parse dates using date parse function
  • [x] Add tests if any

closes #149

totallynotvaishnav avatar Jul 26 '22 19:07 totallynotvaishnav

Coverage Status

Coverage remained the same at 99.171% when pulling f985a83265430d4524220dc1a1fa73950d1613ac on issues/149-use-latest-netjsongraph into f7422560c747641cf400bcc4ef1e3bdd23eea2db on master.

coveralls avatar Jul 28 '22 15:07 coveralls

Screenshot

Screenshot 2022-07-28 at 10 44 27 PM Screenshot 2022-07-28 at 10 44 47 PM

totallynotvaishnav avatar Jul 28 '22 17:07 totallynotvaishnav

Hi, there is small issue that can be seen at https://demo.openwisp.io/admin/topology/topology/6c04a21b-30d9-48f3-8757-023cb6328731/change/

  1. click on "View topology graph" => there is nice star link graph
  2. close the graph with big white X in the top right corner => you get back to management panel
  3. click on "View topology graph" again => no topology is loaded

mwarning avatar Jul 29 '22 20:07 mwarning

Hi, there is small issue that can be seen at https://demo.openwisp.io/admin/topology/topology/6c04a21b-30d9-48f3-8757-023cb6328731/change/

  1. click on "View topology graph" => there is nice star link graph
  2. close the graph with big white X in the top right corner => you get back to management panel
  3. click on "View topology graph" again => no topology is loaded

Seems like a bug. I will look into this.

totallynotvaishnav avatar Jul 29 '22 20:07 totallynotvaishnav

Merged in #153, thanks!

nemesifier avatar Sep 20 '22 15:09 nemesifier