openwisp-controller icon indicating copy to clipboard operation
openwisp-controller copied to clipboard

Published 20 hours ago • verified publisher icon openwisp

[change] RFC: Add VS Code devcontainer

Open mips171 opened this issue 3 years ago • 4 comments

Use

Open the folder in VS Code. Set your Git credentials in post_create.sh then click rebuild and open in container when prompted

mips171 avatar Nov 27 '22 04:11 mips171

Coverage Status

Coverage remained the same at 98.822% when pulling bdacd4b44e4f5d96c6ef343a1fb55cb82ae84e49 on mips171:mips171/add_devcontainer into cfa9d699c7acb7a67ff9ebbc70088d851e44a3d3 on openwisp:master.

coveralls avatar Nov 27 '22 05:11 coveralls

Do we really want to add editor-specific code to the repo? IMO this doesn't belong here.

okraits avatar Nov 27 '22 19:11 okraits

Do we really want to add editor-specific code to the repo? IMO this doesn't belong here.

Yeah I see your point. Not sure, maybe it belongs here? https://github.com/openwisp/openwisp-dev-env

mips171 avatar Nov 27 '22 20:11 mips171

Do we really want to add editor-specific code to the repo? IMO this doesn't belong here.

Yeah I see your point. Not sure, maybe it belongs here? https://github.com/openwisp/openwisp-dev-env

Yes, probably a better fit. Providing an easy way to set up a dev environment is a good thing but IMO it should be editor-independent.

okraits avatar Nov 27 '22 21:11 okraits