openwisp-controller icon indicating copy to clipboard operation
openwisp-controller copied to clipboard

[change] Made organization fields autocomplete #521

Open pandafy opened this issue 4 years ago • 2 comments

Closes #521

pandafy avatar Aug 25 '21 19:08 pandafy

I have thought a bit more about this and I don't think it's going in the right direction, moreover I had underestimated the effort required to do this.

OpenWISP Users

It may make more sense to add the core of this code to openwisp-users instead of here.

Selenium tests should be used for our UI

Writing selenium tests for this doesn't look beneficial to me because we aren't testing our own UI but we're testing something which is shipped in django.

Can we think about an alternative approach? There should be a view automatically created by django and used to fetch the data right? If yes we should be able to use that right?

Yes, I had this thought too. A test which ensures that a user which view permission of organization model should be able to query autocomplete view created by django admin. And the rest of the code can be discarded.

pandafy avatar Aug 26 '21 13:08 pandafy

TODO: "Available Systemwide" is also shown in organization field on device admin.

pandafy avatar Sep 02 '21 11:09 pandafy