openwisp-controller icon indicating copy to clipboard operation
openwisp-controller copied to clipboard
verified publisher icon openwisp

[change] Allow multiple jsonschema widgets in one page

Open nemesifier opened this issue 5 years ago • 3 comments

Earlier the schema.json was bound to each view. No matter how many different switcher were present, it was only loading one of them.

With this patch, fetching schema.json is bound to each switcher element. This allows fetching different JSONSchemas on the same page.

nemesifier avatar Dec 04 '20 15:12 nemesifier

Coverage Status

Coverage increased (+0.0008%) to 99.174% when pulling a53c16cfee43e6f98a1a5fd372847cea96fda964 on improve-jsonwidget into fcfa337ceb11ff85ad8922e7576f6c223185bc95 on master.

coveralls avatar Dec 04 '20 15:12 coveralls

@pandafy I found a minor issue while testing the widget in the credentials edit page, can you replicate it?

Yes, I am able to replicate it and it is occurring on master branch as well. I have opened #334 for it.

I believe it is unrelated to this PR.

@pandafy you're right, so I think we can merge this one. Do you agree?

nemesifier avatar Dec 04 '20 18:12 nemesifier

@pandafy Thanks for your integration.

I have also noticed the advanced mode code in the JS refers to an ID, but the CSS paths should be converted to use classes.

nemesifier avatar Dec 07 '20 16:12 nemesifier