openwisp-controller icon indicating copy to clipboard operation
openwisp-controller copied to clipboard

[feature] REST API: allow filtering devices by location ID and floorplan ID

Open nemesifier opened this issue 1 month ago • 9 comments

Add the following filters to the device list API endpoint:

  • location: filter devices having a DeviceLocation object relating to the location ID
  • floorplan: filter devices having a DeviceLocation object relating to the floorplan ID

nemesifier avatar Oct 31 '25 13:10 nemesifier

@nemesifier can i work on this ?

Piyushrathoree avatar Nov 03 '25 22:11 Piyushrathoree

Hi @nemesifier , I’d like to work on this issue — thank you for maintaining such a well-structured project!

I’m a student developer experienced in Python, Django, and REST API integrations, with prior contributions to open-source projects focused on backend optimization and code quality improvements. My approach will involve reproducing the issue locally, reviewing the related module logic, and implementing a consistent fix following OpenWISP’s coding standards and test coverage requirements. I’ll also ensure thorough testing and documentation updates as needed.

I can submit a PR within 3–5 days once assigned. Kindly assign this issue to me — I’d be glad to contribute!

lakshay909 avatar Nov 07 '25 05:11 lakshay909

Hey @lakshay909, I think @Piyushrathoree is already working on this.

@Piyushrathoree can you confirm if we are already working on this issue?

pandafy avatar Nov 07 '25 07:11 pandafy

Hey @lakshay909, I think @Piyushrathoree is already working on this.

@Piyushrathoree can you confirm if we are already working on this issue?

Yeah I'm working on this , and soon raise the PR too

Piyushrathoree avatar Nov 07 '25 09:11 Piyushrathoree

Hi, I saw that this task isn't closed as of now. I would like to work on this

ssmadhavan006 avatar Nov 30 '25 18:11 ssmadhavan006

Hi @nemesifier, If this issue is still unassigned / pending, I’d be happy to take it up. I recently submitted a PR for another issue in this repo, so I can start working on this one immediately as well Please assign the issue to me when convenient. I’ll share the PR when it’s ready.

Srinath0916 avatar Dec 02 '25 06:12 Srinath0916

Hi, @Srinath0916, I am currently working on this

ssmadhavan006 avatar Dec 02 '25 06:12 ssmadhavan006

Thanks for the update @ssmadhavan006.

Just to clarify, I actually started working on this a 2 days ago and the implementation along with the required test cases is already complete on my local setup.

Since there is currently no PR open for this issue, I’ll go ahead and submit one so the maintainers can review it, if u hadn't completed the issue yet.

Srinath0916 avatar Dec 02 '25 06:12 Srinath0916

Hey @Srinath0916 , thanks for letting me know and updating the thread. I appreciate your initiative on this! I also started working on this a couple of days ago and have been making progress locally, but since you already have a finished implementation, please go ahead and submit the PR for review. If there’s any feedback, additional improvements, or testing needed after your PR is up, I’d be happy to help with review or further enhancements! Looking forward to seeing your solution merged.

ssmadhavan006 avatar Dec 02 '25 07:12 ssmadhavan006