openwisp-controller icon indicating copy to clipboard operation
openwisp-controller copied to clipboard
verified publisher icon openwisp

[change] Switched 'Background API Task' notification to 'Generic Mess…

Open stktyagi opened this issue 6 months ago • 2 comments

…age' #1048

Changed the notification format to generic and adjusted tests to cooperate with the change too.

Fixes #1048

Checklist

  • [x] I have read the OpenWISP Contributing Guidelines.
  • [x] I have manually tested the changes proposed in this pull request.
  • [ ] I have written new test cases for new code and/or updated existing tests for changes to existing code.
  • [ ] I have updated the documentation.

Reference to Existing Issue

Closes #1048.

Description of Changes

replaced api_task_{type} for both error and recovery and modified tests to support the changes.

stktyagi avatar Jun 19 '25 18:06 stktyagi

one thing more that is left and would be required is changes to test and fiile function names to follow the change structure. Few being :-

test_zerotier_api_tasks_notification and _send_api_task_notification

I'll make sure to do these after a review and further steps on the current changes.

stktyagi avatar Jun 19 '25 18:06 stktyagi

Coverage Status

coverage: 98.746% (-0.03%) from 98.777% when pulling 7282a194d891ee008d7d747cd4e3336b3c0de08e on stktyagi:master into 2295ce977141c632858feb5aaab6efebd026e259 on openwisp:master.

coveralls avatar Jun 19 '25 18:06 coveralls