netjsongraph.js
netjsongraph.js copied to clipboard
openwisp
[deps] Update dependencies
There's a bunch of dependabot PRs which fail to complete the test build successfully: https://github.com/openwisp/netjsongraph.js/pulls which would be good to fix.
I think upgrading to the latest version of echarts may also help resolve some quirks we've been having.
i am really sorry to ask this type of the question but please help me in this i saw the bunch of pull requests which made by the dependabot and ur saying that its failing the test cases right ? in what way we can fix them like any hint bcz i want to solve this issue.any suggestion that u want give to fix this issue.
i am really sorry to ask this type of the question but please help me in this i saw the bunch of pull requests which made by the dependabot and ur saying that its failing the test cases right ? in what way we can fix them like any hint bcz i want to solve this issue.any suggestion that u want give to fix this issue.
What we do is to run the tests in our local development environment, read the error output and figure out what needs to be updated.
@nemesifier Should it be tested by upgrading ALL dependencies? Or only the echarts one first
@Shiva953 pinpointing the source of errors can become challenging when upgrading all libraries simultaneously. I suggest upgrading dependencies individually and testing them incrementally. Start by upgrading one dependency, run tests, and proceed if there are no errors. If issues arise, investigate test failures, review the dependency's changelog for potential breaking changes, and adjust the code accordingly to ensure compatibility with the latest version.
@Shiva953 pinpointing the source of errors can become challenging when upgrading all libraries simultaneously. I suggest upgrading dependencies individually and testing them incrementally. Start by upgrading one dependency, run tests, and proceed if there are no errors. If issues arise, investigate test failures, review the dependency's changelog for potential breaking changes, and adjust the code accordingly to ensure compatibility with the latest version.
Incrementally referring to all on the same branch(upgrading one after the other) OR individual branches for each dependency upgradation(for testing)?
You can send one PR with separate commit for each dependency. I would recommend to review the PRs created by dependabot with failing CI and then try to replicate the issue locally.
You may find some dependencies which would not work without updating another dependency. For such cases, just create one commit for related dependencies.
You can send one PR with separate commit for each dependency. I would recommend to review the PRs created by dependabot with failing CI and then try to replicate the issue locally.
You may find some dependencies which would not work without updating another dependency. For such cases, just create one commit for related dependencies.
Thanks, opened a PR. The QA checks are successful from my side.