django-rest-framework-gis icon indicating copy to clipboard operation
django-rest-framework-gis copied to clipboard
verified publisher icon openwisp

Should probably by 'intersects' rather than 'bboverlaps'

Open joshuamaxwell opened this issue 7 years ago • 2 comments

https://github.com/djangonauts/django-rest-framework-gis/blob/8febe79fb8291f20b8f6e9c53ac8db8a24ceb26e/rest_framework_gis/filters.py#L65

The bboverlaps comparison will only return geometries whose boundaries cross over the bbox but it WILL NOT return any geometries that are wholly contained within the bbox (at least not for mySQL/mariaDB)

joshuamaxwell avatar Feb 05 '18 19:02 joshuamaxwell

Changing the behaviour may lead to unwanted behaviour in applications that depend on this library.

Maybe the best path is to document this properly and add also the possibility to use the other filter.

nemesifier avatar Apr 28 '18 14:04 nemesifier

@joshuamaxwell do you have any suggestion regarding this?

nemesifier avatar Aug 18 '20 21:08 nemesifier